Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: KryptonMessagebox is not RTL compliant #313

Closed
Smurf-IV opened this issue Sep 1, 2021 · 11 comments
Closed

[Bug]: KryptonMessagebox is not RTL compliant #313

Smurf-IV opened this issue Sep 1, 2021 · 11 comments
Labels
bug Something isn't working fixed This issue has been fixed. regression Something was working in a previous release, but isn't working now.
Milestone

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Sep 1, 2021

May have to do what Winforms internal do, and have a "Special" version of the messagebox for RTL. This would be the easiest way to ensure "compliance"

@Smurf-IV Smurf-IV added the bug Something isn't working label Sep 1, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Sep 1, 2021

@Wagnerp
Copy link
Contributor

Wagnerp commented Sep 1, 2021

This might actually straddle the Toast module in the ET as well.

@Smurf-IV Smurf-IV self-assigned this Sep 13, 2021
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Sep 13, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Sep 13, 2021

What a Winform MessageBox looks like (With both settings):
image

What the "Current" Krypton MB looks like:
image

@Smurf-IV
Copy link
Member Author

Just RightAlign looks like this:
image

And Just RTL looks like this:
image

So the settings appear to be exclusive. (Unless it detects RTL in the OS, and the Font used ??)

@Smurf-IV
Copy link
Member Author

With the Fix:
Both Set:
image

RightAlign only:
image

RTL Only:
image

Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Sep 13, 2021
@Smurf-IV Smurf-IV changed the title [Bug]: 2109 Canary messagebox is not RTL compliant [Bug]: KryptonMessagebox is not RTL compliant Sep 13, 2021
Smurf-IV added a commit that referenced this issue Sep 13, 2021
@Smurf-IV Smurf-IV removed their assignment Sep 13, 2021
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Sep 13, 2021
@Wagnerp Wagnerp added regression Something was working in a previous release, but isn't working now. and removed completed This issue has been completed. labels Jan 13, 2024
@Wagnerp
Copy link
Contributor

Wagnerp commented Jan 13, 2024

Using today's alpha 13/01/2024

Bug 313

@Wagnerp Wagnerp reopened this Jan 13, 2024
@Wagnerp
Copy link
Contributor

Wagnerp commented Jan 14, 2024

@Smurf-IV Was something changed between v70 & v80?

@Smurf-IV
Copy link
Member Author

@Wagnerp
I seem to remember that you introduced Layout tables for the Bottom extension stuff.

@Wagnerp
Copy link
Contributor

Wagnerp commented Jan 14, 2024

@Wagnerp I seem to remember that you introduced Layout tables for the Bottom extension stuff.

@Smurf-IV I wonder... What if we had two sets of tables? I'll prototype something this week...

@Wagnerp Wagnerp added this to the Version 90 milestone Jan 14, 2024
@Wagnerp Wagnerp self-assigned this Jan 14, 2024
@Wagnerp Wagnerp added the under investigation This bug/issue is currently under investigation. label Jan 14, 2024
@Wagnerp
Copy link
Contributor

Wagnerp commented Jan 15, 2024

Fixed

Bug 313

Wagnerp added a commit that referenced this issue Jan 15, 2024
@Wagnerp Wagnerp removed their assignment Jan 16, 2024
@Wagnerp Wagnerp added fixed This issue has been fixed. and removed under investigation This bug/issue is currently under investigation. labels Jan 16, 2024
@Wagnerp Wagnerp closed this as completed Jan 16, 2024
@Wagnerp
Copy link
Contributor

Wagnerp commented Jan 16, 2024

Hi @Ahmed-Abdelhameed

Would you mind testing today's nightly build, .16 to see whether this works correctly? I know that the buttons and form chrome still needs to be flipped around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This issue has been fixed. regression Something was working in a previous release, but isn't working now.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants