Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Krypton Form - ButtonSpec (And Icon), are Cut Off when maximised #333

Closed
MattH-Work opened this issue Sep 9, 2021 · 14 comments
Closed
Labels
bug Something isn't working completed This issue has been completed.
Milestone

Comments

@MattH-Work
Copy link

Describe the bug
When maximising a Krypton Form, ButtonSpecs & icons are cut off (see image)
I have marked in Red the space between the form icon (left) and buttonspec text / icon (right) relative to the edge of the form both 'normal' & maximised, top view is normal, bottom view is maximised

Cropped

@MattH-Work MattH-Work added the bug Something isn't working label Sep 9, 2021
@Smurf-IV
Copy link
Member

Smurf-IV commented Sep 9, 2021

@MattH-Work

  • What version have you found this in?
  • What OS
  • Which TFM
  • And is the App DPI / High DPI / etc aware via Manifest or TFM settings ?
  • And Which Theme

Cheers

@MattH-Work
Copy link
Author

MattH-Work commented Sep 9, 2021 via email

@sdreb3421
Copy link

I've also found this to be true for all versions.

@Smurf-IV Smurf-IV self-assigned this Sep 12, 2021
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Sep 12, 2021
@Smurf-IV
Copy link
Member

FYI: TFM https://docs.microsoft.com/en-us/nuget/reference/target-frameworks

I have found that different themes deal with the icon in different ways.
The ButtoneSpec is always cut of if using a full height icon
The Form max / mins are also cut off in different ways dependent on the the theme.

@sdreb3421
Copy link

@Smurf-IV @Wagnerp it looks like it's an overall form issue, not just a button spec icon issue. Looks like about 10px cut off around all edges when maximized. Do you guys see that? If you guys can't see it at all I'll go investigate what OS/TFM this applies to.

@Smurf-IV
Copy link
Member

Do you guys see that?

Yes - Currently investigating.

Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Sep 12, 2021
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Sep 12, 2021
Smurf-IV added a commit that referenced this issue Sep 12, 2021
- Update margins and offset values to display coorectly in full screen
Fixes #333
@Smurf-IV Smurf-IV changed the title [Bug]: Krypton Form - ButtonSpec, Cut Off When Maximised [Bug]: Krypton Form - ButtonSpec (And Icon), are Cut Off when maximised Sep 12, 2021
@Smurf-IV
Copy link
Member

Fixed: Notice that

  • the Close button now shows Curvature
  • The icon for the FullHeight ButtonSpec is visible
    image
  • The Form icon is fully visible
    image

@Smurf-IV Smurf-IV added this to the November 2021 (Version 6) milestone Sep 12, 2021
@sdreb3421
Copy link

@Smurf-IV is this included in the nightly build? I'm not seeing a difference on my end for Nightly 266. The picture on the left is form not maximized, the picture on the right is the form maximized. I investigated the behavior of a regular form and it also seems to shrink the header, but it does not shrink the left/right/bottom edges.

Form border
.

@Wagnerp
Copy link
Contributor

Wagnerp commented Sep 26, 2021

@Smurf-IV Is this a padding bug?

@Wagnerp Wagnerp reopened this Sep 26, 2021
@Smurf-IV
Copy link
Member

@Smurf-IV Is this a padding bug?

No, It was theme related, I thought I managed to get it int the base, but if this is a "Special theme" then perhaps "the fix" needs to be moved into the general area.
Please check the changes in #337 to make sure they got into the nightly.

@sdreb3421
Copy link

Not sure if my original statement was totally clear. It's the entire form's border edges, not just the header that is being cut off. Thanks

@Wagnerp
Copy link
Contributor

Wagnerp commented Sep 27, 2021

@Smurf-IV Is this a padding bug?

No, It was theme related, I thought I managed to get it int the base, but if this is a "Special theme" then perhaps "the fix" needs to be moved into the general area.
Please check the changes in #337 to make sure they got into the nightly.

They were pushed into nightly, maybe a custom theme?

@Smurf-IV
Copy link
Member

Just tested with the themes that come with "6.2109.268-alpha"
And it appears the fix is working as expected on Win 10 x64 1809

@sdreb3421 some Questions:

  1. What OS are you using,
  2. What Resolution of monitor are you using,
  3. Is you app manifest been set to dpi aware (via manifest or code if .net 5),
  4. Are the Forms been set to dpi aware (Not font) scaling

@Smurf-IV Smurf-IV removed their assignment Oct 10, 2021
@Wagnerp
Copy link
Contributor

Wagnerp commented Oct 25, 2021

Fixed in build 2201

@Wagnerp Wagnerp closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed This issue has been completed.
Projects
None yet
Development

No branches or pull requests

4 participants