Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Other Issues]: DropShadow should now be off and deprecated #551

Closed
Smurf-IV opened this issue Dec 30, 2021 · 7 comments
Closed

[Other Issues]: DropShadow should now be off and deprecated #551

Smurf-IV opened this issue Dec 30, 2021 · 7 comments
Labels
completed This issue has been completed. discussion Discussion thread. other All other issues.
Milestone
Version 7

Comments

@Smurf-IV
Copy link
Member

UseDropShadow should not really be a "Thing" any more, as blur values, and proper shadowing are the norm in Windows 7 onwards.
image

At least default to False
@Smurf-IV Smurf-IV added discussion Discussion thread. other All other issues. labels Dec 30, 2021
@Wagnerp
Copy link
Contributor

Wagnerp commented Dec 30, 2021

@Smurf-IV Might be a change for V7 + drop support for Windows 7/8 & maybe 8.1?

@Smurf-IV
Copy link
Member Author

Still a lot of OS installs that are still running Win 7 & 8.1
So there will always be a need for backward compatible whilst .net4.x is supported.
Not sure 7 is far enough away.

@Wagnerp Wagnerp added this to the Version 7 milestone Dec 30, 2021
@Wagnerp Wagnerp self-assigned this Dec 30, 2021
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jan 2, 2022

This is the suspect code that performs a force set in >= Windows 10

image

@Wagnerp
Copy link
Contributor

Wagnerp commented Jan 2, 2022

@Smurf-IV Might implement a version check aimed specifically @ Win 7 for this.

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jan 2, 2022

You will have to check the existing Demo Ribbon app to see what affects it has on "ALL" supported OS's (i.e. 8, and 8.1 as well)

@Smurf-IV
Copy link
Member Author

Just remove Lines 190 -> 199, then this can be closed.
Let the developer choose !

@Wagnerp Wagnerp added the in progress A fix for this issue is in the works. label Feb 27, 2022
Wagnerp added a commit that referenced this issue May 18, 2022
@Wagnerp
* Implement #551
7b67d36
@Wagnerp Wagnerp mentioned this issue May 18, 2022
Merged
@Wagnerp Wagnerp removed their assignment May 18, 2022
@Wagnerp Wagnerp added completed This issue has been completed. and removed in progress A fix for this issue is in the works. labels May 18, 2022
@Wagnerp
Copy link
Contributor

Wagnerp commented May 18, 2022

Implemented - 18/05/2022

@Wagnerp Wagnerp closed this as completed May 18, 2022
Smurf-IV added a commit that referenced this issue May 19, 2022
@Smurf-IV
Merge pull request #713 from Krypton-Suite/vn-OI#551
ee4a4a9 
* Implement #551
Wagnerp added a commit that referenced this issue May 19, 2022
@Wagnerp
* Fix fallout from #551
fd6b769
@Wagnerp Wagnerp mentioned this issue May 19, 2022
Merged
Smurf-IV added a commit that referenced this issue May 19, 2022
@Smurf-IV
Merge pull request #714 from Krypton-Suite/vn-OI#551
52504ec 
* Fix fallout from #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed This issue has been completed. discussion Discussion thread. other All other issues.
Projects
None yet
Milestone
Version 7
Development

No branches or pull requests
2 participants
@Wagnerp @Smurf-IV