Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Bring MessageBox States inline with latest .Net 6 #728

Closed
Smurf-IV opened this issue Jun 6, 2022 · 14 comments
Closed

[Feature Request]: Bring MessageBox States inline with latest .Net 6 #728

Smurf-IV opened this issue Jun 6, 2022 · 14 comments
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Milestone
Version 8

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 6, 2022 •
edited

https://docs.microsoft.com/en-us/dotnet/desktop/winforms/whats-new/net60?view=netdesktop-6.0#updated-apis

image

===================
Edit:
The "Idea" of these changes is to bring the functionality "Down" from .Net 6 / 7 into the earlier versions, so that a Single code base will work for multi-target builds.
@Smurf-IV Smurf-IV added enhancement New feature or request suggestion A suggestion has been requested. labels Jun 6, 2022
@Wagnerp Wagnerp added this to the Version 7 milestone Jun 6, 2022
@Wagnerp Wagnerp added the new feature A new feature has been requested. label Jun 6, 2022
@Wagnerp
Copy link
Contributor

Wagnerp commented Jun 6, 2022

@Smurf-IV Just thinking about it, do these new features need the #if definition to work? If so, I'll try to tackle some of the messagebox portion of it today.

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jun 6, 2022 •
edited

#if would be one way to "Limit" the functionality,
But... It would be nice if it could be made "Backward compatible" (i.e all the way down down to .net 4.6.2);
This resulting in a single code base for the User developer to use regardless of TFM

Wagnerp added a commit that referenced this issue Jun 6, 2022
@Wagnerp
* Semi implement #728, with points 2 & 4 outstanding
9dda40f
@Wagnerp Wagnerp mentioned this issue Jun 6, 2022
Merged
Smurf-IV added a commit that referenced this issue Jun 11, 2022
@Smurf-IV
Merge pull request #730 from Krypton-Suite/alpha-fr#728
66e42f7 
* Semi implement #728, with points 2 & 4 outstanding
@Wagnerp Wagnerp added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Jun 11, 2022
@Wagnerp
Copy link
Contributor

Wagnerp commented Jun 11, 2022

Needs testing >= .162

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 16, 2022

@Smurf-IV Do we know if this is working, also what is button4 used for?

Wagnerp added a commit that referenced this issue Jul 16, 2022
@Wagnerp
* Implement point # 2 #728
c5e1bba
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jul 17, 2022 •
edited

@Smurf-IV Do we know if this is working,

It is displayed via a new System API, where uType has all the "styles" placed into a DWORD:
image

also what is button4 used for?

image

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 17, 2022

@Smurf-IV Do we know if this is working, also what is button4 used for?

image

So, is there a help button now?

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 17, 2022 •
edited

@Smurf-IV I assume the "new" button4 option would go to the left of the existing buttons if it's a dedicated help button?

i.e.

ButtonPanel

Wagnerp added a commit that referenced this issue Jul 17, 2022
@Wagnerp
* Try to implement point 4 of #728
32350af
@Wagnerp Wagnerp mentioned this issue Jul 17, 2022
Merged
@Smurf-IV
Copy link
Member Author

You will have to create a demo app in .Net 6 and try....

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 18, 2022

I'm not sure if we even need this, as a button for help is already catered for

@Wagnerp
Copy link
Contributor

Wagnerp commented Jul 18, 2022

Got it!! PR coming soon

Wagnerp added a commit that referenced this issue Jul 18, 2022
@Wagnerp
* Do point 2 #728
28ecc2a
Smurf-IV added a commit that referenced this issue Jul 24, 2022
@Smurf-IV
Merge pull request #785 from Krypton-Suite/alpha-fr#728msgbox
96d3394 
* Try to implement point 4 of #728
@Wagnerp Wagnerp modified the milestones: Version 7, Version 8 Oct 23, 2022
@Smurf-IV Smurf-IV removed the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Dec 4, 2022
@Smurf-IV Smurf-IV self-assigned this Dec 4, 2022
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Dec 11, 2022
@Smurf-IV Smurf-IV mentioned this issue Dec 11, 2022
Closed
@Smurf-IV
Copy link
Member Author

@Wagnerp I think in order to get "Backward compatible with previous versions of TFM", _we_would need to use a krypton type for buttons etc. Like you did for the Icons. e.g.
MessageBoxButtons -> KyrptonMessageBoxButtons

Thuoghts ?

@Wagnerp
Copy link
Contributor

Wagnerp commented Dec 11, 2022

@Wagnerp I think in order to get "Backward compatible with previous versions of TFM", _we_would need to use a krypton type for buttons etc. Like you did for the Icons. e.g. MessageBoxButtons -> KyrptonMessageBoxButtons

Thuoghts ?

@Smurf-IV No problem, I may look into the feasibility of #866

@Wagnerp
Copy link
Contributor

Wagnerp commented Dec 11, 2022

@Smurf-IV I think I did something similar in the extended toolkit, regarding buttons, so you can borrow that code

@Smurf-IV Smurf-IV mentioned this issue Dec 11, 2022
Closed
@Smurf-IV
Copy link
Member Author

Point 1 done:
MBox

Smurf-IV added a commit that referenced this issue Dec 11, 2022
@Smurf-IV
- Add in new KryptonMessageBoxButtons type that emualtes the .net6 …
e4e1df6 
…`MessageBoxButtons`

- Fix fallout for the new dialogResult type
- Fix Help button not being shown
- Add missing `private` monikers
- Fix usage of controls in the KryptonMessageBox demo
- Remove some usages of .net 5
- Remove some compile warnings / messages from Example projects

##867
##728)
Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Dec 11, 2022
@Smurf-IV
- Add in new KryptonMessageBoxButtons type that emualtes the .net6 …
022b43f 
…`MessageBoxButtons`

- Fix fallout for the new dialogResult type
- Fix Help button not being shown
- Add missing `private` monikers
- Fix usage of controls in the KryptonMessageBox demo
- Remove some usages of .net 5
- Remove some compile warnings / messages from Example projects

#Krypton-Suite/Standard-Toolkit#867
#Krypton-Suite/Standard-Toolkit#728)
This was referenced Dec 11, 2022
Merged
Closed
@Smurf-IV Smurf-IV removed their assignment Dec 11, 2022
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed This issue has been completed. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Milestone
Version 8
Development

When branches are created from issues, their pull requests are automatically linked.

alpha-728-MBoxStates Krypton-Suite/Standard-Toolkit
2 participants
@Wagnerp @Smurf-IV