rfc: configuration of kuadrant sub components #25

Boomatang · 2023-09-11T13:03:42Z

Address needs of Kuadrant/kuadrant-operator#163
Related issue: Kuadrant/kuadrant-operator#164

alexsnaps · 2023-09-11T13:33:09Z

This might be of interest to this:
Kuadrant/limitador-operator#96

rfcs/0000-kuadrant_sub_components_configurations.md

maleck13 · 2023-11-10T09:57:15Z

rfcs/0000-kuadrant_sub_components_configurations.md

+#### Kubernetes native
+- replicas
+
+#### Observability


what am I setting when configuring these? LogLevel is obvious, but what is the value to exposing Healthz, Metrics, Tracing ? Should these be things we set as part of the kaudrant install. I guess I am struggling to see the use case for setting some of these and perhaps we should limit down the set we want to expose further @alexsnaps ?

maleck13

I think it is reasonable to allow some of the configuration options to bubble up to the kuadrant CR. I have concerns with how many we are proposing. I am not sure we have clear use case for each of them. The redis url has a clear use case for example, but I don't know why I am setting the number replicas for example (why can't I just scale up the deployment) this seems more complex than what is needed. I worry a little about leaking things that exist in established APIs such as deployments up through not one but two CRs. Personally I have become more of a fan of you get the default deployment and there are things you can chane about that if you want (IE numbr of replicas)

Boomatang · 2023-11-13T09:14:52Z

@maleck13 On the concern about the number of configuration options that are bubbling up to the Kuadrant CR. I am happy to reduce the number, it would be better to start with a lesser number and expend the number options at a later date. As for the number of replicas being configured, in the case of limitador it is not recommend to change this in the deployment as depending on what storage option is selected the number of replicas will be restricted.

We have also had a number of issues opened against limitador-operator asking to move configuration options into the limitador CR, this is extending their use case.

guicassolato · 2023-11-13T13:29:36Z

rfcs/0000-kuadrant_sub_components_configurations.md

@@ -0,0 +1,237 @@
+# Configuration of Kuadrant Sub Components
+
+- Feature Name: Configuration of Kuadrant Sub components.


Suggested change

- Feature Name: Configuration of Kuadrant Sub components.

- Feature Name: `sub-components-config`

What is the reasoning behind this change?

Following the pattern from other RFCs. I think the idea for this is to be like a unique identifier that can be used to track the feature unequivocally across, e.g., file names, etc. It helps avoid overloading words and related confusion of such of when relying otherwise only on the human version of it (which is already in the title, BTW.)

guicassolato · 2023-11-13T18:32:29Z

rfcs/0000-kuadrant_sub_components_configurations.md

+[motivation]: #motivation
+
+The initial request comes from MGC to configure Redis for Limitador by the following issue [#163](https://github.com/Kuadrant/kuadrant-operator/issues/163).
+MGCs current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.


Suggested change

MGCs current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.

MGC's current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.

guicassolato · 2023-11-13T18:32:44Z

rfcs/0000-kuadrant_sub_components_configurations.md

+This change would allow for the configuration sub components before the Kuadrant is deployed. 
+
+As a kuadrant user this reduces the number of CRs that they are required to modify to get the installation they require.
+The sub components CRDs (Authorino, Limitador) never have to be modified by a Kuadrant user (and should never be modified by a Kuadrant User).


Suggested change

The sub components CRDs (Authorino, Limitador) never have to be modified by a Kuadrant user (and should never be modified by a Kuadrant User).

The sub components CRs (Authorino, Limitador) never have to be modified by a Kuadrant user (and should never be modified by a Kuadrant User).

guicassolato · 2023-11-13T18:34:08Z

rfcs/0000-kuadrant_sub_components_configurations.md

+
+The initial request comes from MGC to configure Redis for Limitador by the following issue [#163](https://github.com/Kuadrant/kuadrant-operator/issues/163).
+MGCs current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.
+This change would allow for the configuration sub components before the Kuadrant is deployed. 


Suggested change

This change would allow for the configuration sub components before the Kuadrant is deployed.

This change would allow for the configuration of sub components before the Kuadrant is deployed.

guicassolato · 2023-11-13T18:37:25Z

rfcs/0000-kuadrant_sub_components_configurations.md

+MGCs current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.
+This change would allow for the configuration sub components before the Kuadrant is deployed. 
+
+As a kuadrant user this reduces the number of CRs that they are required to modify to get the installation they require.


Suggested change

As a kuadrant user this reduces the number of CRs that they are required to modify to get the installation they require.

This reduces the number of CRs that users of Kuadrant are required to modify to get the installation they require.

guicassolato · 2023-11-13T18:46:14Z

rfcs/0000-kuadrant_sub_components_configurations.md

+- tracing
+
+#### Application Settings
+- eveluatorCacheSize


Suggested change

- eveluatorCacheSize

- evaluatorCacheSize

guicassolato · 2023-11-13T18:46:39Z

rfcs/0000-kuadrant_sub_components_configurations.md

+#### Unsupported
+- clusterWide
+- authConfigLabelSelectors
+- secrtLabelSelectors


Suggested change

- secrtLabelSelectors

- secretLabelSelectors

guicassolato · 2023-11-13T18:49:12Z

rfcs/0000-kuadrant_sub_components_configurations.md

+If a user wishes to use a different image, they can.
+Kuadrant assumes they know what they are doing but requires the user to set the change on the component directly.
+
+Only the sub component operator will be responsible for actioning the configurations pasted form the Kuadrant CR to the sub components CR.


Suggested change

Only the sub component operator will be responsible for actioning the configurations pasted form the Kuadrant CR to the sub components CR.

Only the sub component operator will be responsible for actioning the configurations pasted from the Kuadrant CR to the sub components CR.

guicassolato · 2023-11-13T18:58:27Z

rfcs/0000-kuadrant_sub_components_configurations.md

+Fields being reconcile can be classified into different groups.
+These classifications are based around the tasks a user is achieve.
+
+- Kubernetes native, setting that affect how Kubernetes handles the resource.


I wonder about labels. Are those in this group? Or maybe they could be propagated from the labels of the Kuadrant CR itself. If this is the case, are labels out of scope of the RFC?

The ability to set labels in the components' CRs can be useful for selecting not only these custom resources in particular, but also other resources that the corresponding component operator creates based on those. This is the case of Authorino, whose operator creates services propagating the same labels applied to the Authorino CR, including, e.g., Authorino's metrics service, later used by the scraper to find the service.

Labels are interesting, and would be out of scope of the RFC. This RFC is focusing on the spec of CRs.

If the labels were to be managed you would also need to take into account other updater's of the labels on the resources. The source of truth for the labels becomes a bit muddy.

One thing is for sure. We need a way for users to be able to propagate labels across resources initially created by our controllers.

That said, I can live with labels being out of the scope of this RFC. It should be clear then for one who implements this RFC that reconciling the resources back to the desired state declared in the Kuadrant CR should NOT include the labels (at least not because of this RFC.)

maleck13 · 2023-11-14T10:45:52Z

I am happy to approve as long as we give careful consideration to each value we choose to surface as you mention @Boomatang it is easier to add more than to have to start depreciating and removing

pehala · 2023-11-15T09:23:28Z

rfcs/0000-kuadrant_sub_components_configurations.md

+        resourceRequirements: ...
+        storage: ...
+    authorino:
+        eveluatorCacheSize: ...


Suggested change

eveluatorCacheSize: ...

evaluatorCacheSize: ...

Boomatang added the RFC Request For Comments label Sep 11, 2023

Boomatang mentioned this pull request Sep 11, 2023

Support MGC requirements to configure Redis' URL for limitador Kuadrant/kuadrant-operator#163

Closed

eguzki mentioned this pull request Sep 12, 2023

Custom underlying services #16

Closed

Boomatang force-pushed the rfc/configuration_of_kuadrant_sub_components branch from dd8da75 to 155ea6e Compare September 19, 2023 09:16

Boomatang requested a review from a team September 28, 2023 14:05

pehala reviewed Oct 11, 2023

View reviewed changes

rfcs/0000-kuadrant_sub_components_configurations.md Outdated Show resolved Hide resolved

rfcs/0000-kuadrant_sub_components_configurations.md Outdated Show resolved Hide resolved

rfcs/0000-kuadrant_sub_components_configurations.md Outdated Show resolved Hide resolved

pehala reviewed Oct 18, 2023

View reviewed changes

rfcs/0000-kuadrant_sub_components_configurations.md Outdated Show resolved Hide resolved

rfcs/0000-kuadrant_sub_components_configurations.md Outdated Show resolved Hide resolved

rfc: configuration of kuadrant sub components

e8ce534

Boomatang force-pushed the rfc/configuration_of_kuadrant_sub_components branch from 155ea6e to e8ce534 Compare October 20, 2023 10:03

Boomatang added the status/FCP Final Comment Period label Nov 9, 2023

maleck13 reviewed Nov 10, 2023

View reviewed changes

guicassolato reviewed Nov 13, 2023

View reviewed changes

pehala reviewed Nov 15, 2023

View reviewed changes

Boomatang added 2 commits November 15, 2023 14:33

Updates for PR comments.

b25bc2e

Update RFC Metadata

2c71f9a

guicassolato approved these changes Nov 16, 2023

View reviewed changes

Boomatang merged commit bfa229c into main Nov 16, 2023
1 check passed

eguzki deleted the rfc/configuration_of_kuadrant_sub_components branch November 16, 2023 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rfc: configuration of kuadrant sub components #25

rfc: configuration of kuadrant sub components #25

Boomatang commented Sep 11, 2023 •

edited by eguzki

Loading

alexsnaps commented Sep 11, 2023

maleck13 Nov 10, 2023

maleck13 left a comment •

edited

Loading

Boomatang commented Nov 13, 2023

guicassolato Nov 13, 2023

Boomatang Nov 14, 2023

guicassolato Nov 15, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

guicassolato Nov 13, 2023

Boomatang Nov 14, 2023

guicassolato Nov 15, 2023

maleck13 commented Nov 14, 2023 •

edited

Loading

pehala Nov 15, 2023

		@@ -0,0 +1,237 @@
		# Configuration of Kuadrant Sub Components

		- Feature Name: Configuration of Kuadrant Sub components.

	- Feature Name: Configuration of Kuadrant Sub components.
	- Feature Name: `sub-components-config`

	MGCs current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.
	MGC's current work around is to update the Limitador CR after the deployment with the configuration setting for Redis Instance.

	The sub components CRDs (Authorino, Limitador) never have to be modified by a Kuadrant user (and should never be modified by a Kuadrant User).
	The sub components CRs (Authorino, Limitador) never have to be modified by a Kuadrant user (and should never be modified by a Kuadrant User).

	This change would allow for the configuration sub components before the Kuadrant is deployed.
	This change would allow for the configuration of sub components before the Kuadrant is deployed.

	As a kuadrant user this reduces the number of CRs that they are required to modify to get the installation they require.
	This reduces the number of CRs that users of Kuadrant are required to modify to get the installation they require.

	Only the sub component operator will be responsible for actioning the configurations pasted form the Kuadrant CR to the sub components CR.
	Only the sub component operator will be responsible for actioning the configurations pasted from the Kuadrant CR to the sub components CR.

rfc: configuration of kuadrant sub components #25

rfc: configuration of kuadrant sub components #25

Conversation

Boomatang commented Sep 11, 2023 • edited by eguzki Loading

alexsnaps commented Sep 11, 2023

Choose a reason for hiding this comment

maleck13 left a comment • edited Loading

Choose a reason for hiding this comment

Boomatang commented Nov 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maleck13 commented Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

Boomatang commented Sep 11, 2023 •

edited by eguzki

Loading

maleck13 left a comment •

edited

Loading

maleck13 commented Nov 14, 2023 •

edited

Loading