Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --tracing-service-insecure #169

Merged

Conversation

adam-cattermole
Copy link
Member

Add new Tracing.Insecure field which adds the --tracing-service-insecure argument to the authorino deployment.

Verification

  1. Create a kind cluster
kind create cluster --name authorino-cluster
  1. Create the namespace for the operator
kubectl create namespace authorino-operator
  1. Install operator manifests from this PR
make install
  1. Deploy image from this PR
OPERATOR_IMAGE=quay.io/acatterm/authorino-operator:tracing-insecure make deploy
  1. Deploy authorino
kubectl -n default apply -f -<<EOF
apiVersion: operator.authorino.kuadrant.io/v1beta1
kind: Authorino
metadata:
  name: authorino
spec:
  listener:
    tls:
      enabled: false
  oidcServer:
    tls:
      enabled: false
  tracing:
    endpoint: invalid-endpoint
EOF
  1. Check args
kubectl get deployment authorino -o yaml | yq '.spec.template.spec.containers[0].args'
# - --tracing-service-endpoint=invalid-endpoint
# - --watch-namespace=default
  1. Set insecure to true
kubectl patch authorino/authorino --type=merge -p '{"spec":{"tracing":{"insecure":true}}}'
  1. Check args again
kubectl get deployment authorino -o yaml | yq '.spec.template.spec.containers[0].args'
# - --tracing-service-endpoint=invalid-endpoint
# - --tracing-service-insecure
# - --watch-namespace=default
  1. Set insecure to false
kubectl patch authorino/authorino --type=merge -p '{"spec":{"tracing":{"insecure":false}}}'
  1. Check args as it has been removed
kubectl get deployment authorino -o yaml | yq '.spec.template.spec.containers[0].args'
# - --tracing-service-endpoint=invalid-endpoint
# - --watch-namespace=default

Resolves #167

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbeb036) 61.63% compared to head (a53465a) 61.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   61.63%   61.78%   +0.14%     
==========================================
  Files           2        2              
  Lines         782      785       +3     
==========================================
+ Hits          482      485       +3     
  Misses        249      249              
  Partials       51       51              
Flag Coverage Δ
unit 61.78% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection 🏆

Thanks, @adam-cattermole!

@adam-cattermole adam-cattermole merged commit cdb55b4 into Kuadrant:main Feb 2, 2024
8 checks passed
@adam-cattermole adam-cattermole deleted the configure-tracing-insecure branch February 2, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support for --tracing-service-insecure
3 participants