Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes panic error when TLSEnabled flag is not set #48

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fixes panic error when TLSEnabled flag is not set #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions controllers/authorino_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,13 +668,15 @@ func (r *AuthorinoReconciler) installationPreflightCheck(authorino *api.Authorin
}

for authServerName, tlsCert := range tlsCerts {
tlsEnabled := tlsCert.Enabled == nil || *tlsCert.Enabled
if tlsEnabled {
if tlsCert.CertSecret == nil {
return r.wrapErrorWithStatusUpdate(
r.Log, authorino, r.setStatusFailed(api.AuthorinoTlsSecretNotProvided),
fmt.Errorf("%s secret with tls cert not provided", authServerName),
)
}

if tlsEnabled := tlsCert.Enabled; tlsEnabled == nil && tlsCert.CertSecret == nil {
return r.wrapErrorWithStatusUpdate(
r.Log, authorino, r.setStatusFailed(api.AuthorinoTlsSecretNotProvided),
fmt.Errorf("%s secret with tls cert not provided", authServerName),
)
} else if *tlsEnabled {
secretName := tlsCert.CertSecret.Name
nsdName := namespacedName(authorino.Namespace, secretName)
if err := r.Get(context.TODO(), nsdName, &k8score.Secret{}); err != nil {
Expand All @@ -690,7 +692,6 @@ func (r *AuthorinoReconciler) installationPreflightCheck(authorino *api.Authorin
)
}
}

}
return nil
}
Expand Down