Tracing enhancements #384
Merged
Tracing enhancements #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n (string) becomes '-tags' (key-value pairs)
eguzki
requested changes
Mar 1, 2023
docs/user-guides/observability.md
Outdated
|
|
||
| Integration with an OpenTelemetry collector can be enabled by supplying the `--tracing-service-endpoint` command-line flag (e.g. `authorino server --observability-service-endpoint=http://jaeger:14268/api/traces`). | ||
|
|
||
| The additional `--tracing-service-tags` command-line flag allow to specify fixed agent-level key-value tags for the trace signals emitted by Authorino (`key1=value1[,keyN=valueN]*`). |
There was a problem hiding this comment.
have you considered supporting multiple flags? That would leave the parsing logic to the CLI lib.
authorino server --tracing-service-tags a=1 --tracing-service-tags b=2
There was a problem hiding this comment.
I have not, but it's a good idea. It feels more Golang flags.
Done.
guicassolato
force-pushed
the
tracing-enhancements
branch
from
e71c1a9
to
eead461
Compare
…f comma-separated
eguzki
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observability-*cmd-line flags renamed astracing-*– so it's clear this is the only kind of signal being pushed, other types would require their own separate endpoints anywayseedflag turned into a string array flag that accepts key=value pairs, renamedtagRelated to #163