Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra metrics handler #458

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: extra metrics handler #458

merged 1 commit into from
Mar 5, 2024

Conversation

guicassolato
Copy link
Collaborator

@guicassolato guicassolato commented Mar 5, 2024

Options for the extra metrics handler of the controller manager need to be set before creating the manager.
Otherwise, the /server-metrics endpoint will not be included and return a 404.

Verification steps

make local-setup FF=1
kubectl port-forward service/authorino-controller-metrics 8080:8080 2>&1 >/dev/null &
curl http://localhost:8080/server-metrics

You should see the server metrics and not a 404 Not Found.

@guicassolato guicassolato self-assigned this Mar 5, 2024
@guicassolato guicassolato requested a review from a team March 5, 2024 16:48
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, verified on main receive a 404 page not found, whereas from these changes successfully retrieves the metrics.

@guicassolato guicassolato merged commit 991b6eb into main Mar 5, 2024
10 checks passed
@guicassolato guicassolato deleted the fix-extra-metrics-handler branch March 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants