Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for s390x & ppcl64e architecture #467

Merged
merged 0 commits into from
Jun 3, 2024

Conversation

modassarrana89
Copy link
Contributor

Updated Github workflow to support multi-arch

Copy link

gitguardian bot commented May 30, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11389370 Triggered Username Password 41697e16221d6b92f4fb2de2d2f78ea10fb38ca9 .github/workflows/build-images.yaml View secret
11389370 Triggered Username Password 89bc66ab26c0cec1ebdb5bbf04b96e24a363850b .github/workflows/build-images.yaml View secret
11389370 Triggered Username Password 64c8e1648a264d5b8f5acfed2a2571601a330668 .github/workflows/build-images.yaml View secret
11389370 Triggered Username Password e1e2aa68f09e93c4739f8724ab9bd2ff1e2a25b5 .github/workflows/build-images.yaml View secret
11389371 Triggered Generic High Entropy Secret 0b85b788c3cc2d91216c844c3d997c4ed8b9eb90 .github/workflows/build-images.yaml View secret
11389371 Triggered Generic High Entropy Secret e1e2aa68f09e93c4739f8724ab9bd2ff1e2a25b5 .github/workflows/build-images.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@modassarrana89
Copy link
Contributor Author

modassarrana89 commented May 30, 2024

@jasonmadigan @thomasmaas @maleck13 @alexsnaps Please review changes

@guicassolato
Copy link
Collaborator

Thanks for the PR @modassarrana89.

I'm running the workflow now: https://github.com/Kuadrant/authorino/actions/runs/9303477739/job/25605860414

Let's see how it goes.

@modassarrana89
Copy link
Contributor Author

Thanks for the PR @modassarrana89.

I'm running the workflow now: https://github.com/Kuadrant/authorino/actions/runs/9303477739/job/25605860414

Let's see how it goes.

Thanks. It has run successfully by the way.

@modassarrana89
Copy link
Contributor Author

modassarrana89 commented May 31, 2024

@guicassolato I have raised another PR ( Kuadrant/authorino-operator#181 ) with similar changes for authorino operator

@guicassolato guicassolato merged this pull request into Kuadrant:main Jun 3, 2024
5 checks passed
guicassolato added a commit that referenced this pull request Jun 3, 2024
Added support for s390x & ppcl64e architecture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants