PRs comming from forks do not push images #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
changed the title
eguzki
force-pushed
the
forks-not-running-image-build
branch
from
862ce61
to
66679d2
Compare
|
Currenlty, the even trigger configuration prevents image building from PRs from forked repos. on:
workflow_dispatch:
push:
branches: ['*']
tags: ['*']the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
GH action runs on pushes coming from forked PR's do not have permissions to access docker image repo in quay.io.
This PR adds some conditionals to skip those steps that would fail otherwise.
But building the image and running smoke tests on the image is still a value for forked PR's, so allowing them as a separated job. Not doing multi-arch build with layer caching as the regular image building, though.
Tested