Replace the UDP replication protocol with gRPC for the distributed store #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore.. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
|
rebased. |
alexsnaps
approved these changes
May 21, 2024
| }, | ||
| Some(Err(err)) => { | ||
| if is_disconnect(&err) { | ||
| println!("peer: '{}': disconnected: {:?}", self.peer_id, err); |
There was a problem hiding this comment.
These could become tracing::{error!, warn!, info!} macros... Same syntax. Error level is enabled by default when launching the server, while warn, info, debug, trace are -v, -vv, -vvv or -vvvv
|
|
||
| async fn process(&mut self, in_stream: &mut Streaming<Packet>) -> Result<(), Status> { | ||
| // Send a MembershipUpdate to inform the peer about all the members | ||
| // We should resend it again if we learn of new members. |
There was a problem hiding this comment.
So the intent is to have every node share the nodes it knows about? Is there a way to "forget about a node"? Or is the idea to keep the set a grow only set?
There was a problem hiding this comment.
Need to think about this one a bit more.. maybe they should have some kinda of lease that gets renewed? not sure.
| use std::path::Path; | ||
|
|
||
| fn main() -> Result<(), Box<dyn Error>> { | ||
| generate_protobuf() |
There was a problem hiding this comment.
This probably should be conditional on the feature being enabled... see cfg!, such as here
Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.