Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --no-default-features and bench #342

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix --no-default-features and bench #342

merged 1 commit into from
May 23, 2024

Conversation

alexsnaps
Copy link
Member

redis-test in our dev-dependencies depends on redis but doesn't enable the async runtime... so this needs to be done explicitly by our crate.

In turn: --no-default-features compiles and lets us run bench on just the in mem store, or that and other *_storages as one decides

@alexsnaps alexsnaps requested a review from chirino May 23, 2024 16:58
chirino
chirino approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@chirino chirino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexsnaps alexsnaps merged commit d3e5110 into main May 23, 2024
8 checks passed
@alexsnaps alexsnaps deleted the bench_deps branch May 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirino chirino chirino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexsnaps @chirino