Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kaudrant resources to ksm permissions #775

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

david-martin
Copy link
Contributor

This has been already applied to the api-upstream branch here, which is needed & referenced by the api-quickstart repo.
However, it should land back on main here as well.

@R-Lawton
Copy link
Contributor

/lgtm

@mikenairn
Copy link
Member

@david-martin Is this still needed?

@david-martin
Copy link
Contributor Author

@mikenairn Yes.
This will become important if we include metrics and dashboards content like what's in the api-quickstart. Right now that is in the experimental section of the docs site and uses the api-upstream branch, where this change has been made.

@mikenairn
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,mikenairn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit acb7043 into Kuadrant:main Feb 22, 2024
11 checks passed
@david-martin
Copy link
Contributor Author

Thanks @mikenairn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants