-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Native 0.62 support #42
Comments
same, Hope to support soon |
Awesome @Kudo, will replace our fork with the npm package and report back here in about 10 hours ;) |
this is working as intended with RN v0.62.0 installed from the npm package. Thanks @Kudo for the timely PR review/merge and publishing the package |
Are there any benchmarks for this against Hermes 0.4.0? |
@Kudo If I don't need intl, can I just install v8-android-nointl, or do I need to install both react-native-v8 and v8-android-nointl? |
@songxiaoliang react-native-v8 is the base library you need that handles everything. Along with that you need v8-android or v8-android-nointl installed too. |
@ammarahm-ed thanks, I have solved this problem through practice. anyway, Currently I am trying the difference between herms and react-native-v8 |
@songxiaoliang If you are creating a memory intensive application, v8 is the best choice to go, it has great garbage collection and memory usage does not peak. |
@Kudo can you release 0.62.1 on npm? there is no needed changes on the patch, running the script is be enough (ran it locally and is all good, but I can't publish :P) |
0.62.2 now :) |
yeah, no changes needed for 0.62.2 either |
Published |
Will find some time to do that. My recent works is about to add inspector support. |
@Kudo Fantastic work. We were trying to come to a decision based on stats to switch over to V8 from hermes. Are the benchmarking's available ? |
@Jeevan-Kishore @codecog |
@Kudo Thanks for your work and the benchmark, jsc looks better than Hermes and v8 from the results ? |
I am sorry that I had a mistake to run benchmarks yesterday. (RNV8 not updated).
@magrinj It's hard to say which JS runtime is better. There were some configurations that may impact to the result. IMO, I would use V8 if apps need heavy JS computing. |
@Kudo is Jit activated on the android package? If not, how would i go about adding this? Appreciate the work you put in here. |
@codecog It's my fault not updated the document. I will update the document later. |
@Kudo Thanks for the direction |
Hi! I am experiencing a significant performance degradation (specially with animations) after the upgrade to |
@gpawlik Could you try RN 0.62.2 with JSC or Hermes? On the other hand, please help me to double check the v8-android* version you used before and after upgrade. |
Thanks @Kudo , I have been using |
@gpawlik I am sorry that getting a little confused from the description:
It looks like Hermes and JSC has no performance issue on RN 0.62.2 but only V8, right? |
Only JSC has no performance issues, v8 has serious issues when it comes to screen transitions, animations and any touchable interactions. The performance isn't much better on Hermes, but I haven't tried it before 0.62.2 so it is difficult to compare. |
@gpawlik do you know what may be causing the perf degradation in your code? In our app, we can use JSC and V8 no problem at all, but if we switch to hermes, we started to see horrible degradation as you described, but the code is so massive that we couldn’t track it down to anything specific. |
@enahum unfortunately I was not able to track down the exact cause of this degradation (similarly, our codebase is massive), but in the coming weeks I might spend more time doing this investigation so I will keep you updated. |
The current JSC has lightweight JIT. From my previous benchmark, the JSC has better performance than Hermes or V8 (not the v8-android-jit version). However, performance highly depends on applications. |
Yes, I use Animated (with |
how should i setup in 0.61.4 @Kudo i'm not able to find similarity in build.gradle file |
Hi!
Is it planned?
The text was updated successfully, but these errors were encountered: