Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable bytecode caching by default #165

Merged
merged 4 commits into from Feb 26, 2023
Merged

Enable bytecode caching by default #165

merged 4 commits into from Feb 26, 2023

Conversation

Kudo
Copy link
Owner

@Kudo Kudo commented Feb 26, 2023

Why

It should be safe to turn on the normal bytecode caching mode by default

How

  • deprecate experimental prebuilt codecache mode
  • enable multiple file codecaching for ram bundle
  • use normal cache mode by default

Why

  • ci passed
  • test app running in release build with cache hit log

@Kudo Kudo marked this pull request as ready for review February 26, 2023 02:54
@Kudo Kudo merged commit 3380d22 into main Feb 26, 2023
@Kudo Kudo deleted the bytecode-caching branch February 26, 2023 02:54
@Kudo Kudo mentioned this pull request Mar 1, 2023
Merged
Kudo added a commit that referenced this pull request Mar 1, 2023
@Kudo
Fix expo integration on android (#170)
e3a3b4c 
# Why

fixes #168

# How

- this is a regression from #165. i would add the original `getBundleAssetName` back.
- add expo android project ci job

# Test Plan

ci passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Kudo