Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The animated text on the pilots roster sometimes "bleeds" into the right adjacent column #13

Closed
3 tasks
OmnesPotens opened this issue Sep 19, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@OmnesPotens
Copy link

OmnesPotens commented Sep 19, 2022

Summary

Currenlty it is possible for the pilotCode vuewriter element to bleed/overflow into the column to the right of it. It should be constrained so that it cannot overflow like this. I have opened an issue for this on the vuewriter repo, more context here.

image

Potential Solutions

  • Break the pilotCode string into pieces and pass it in as an actual array, this should force each passed in string to only be written after the previous one has been removed. (This probably isn't a complete solution and the animated effect wouldn't look as great)
  • Wait for the above linked issue/feature request to be completed and update to the new version
  • Replace vuewriter with a different library that can handle this element and the animation (with custom styling)
    Potential replacements:
    • typeit Used by the compcon app
    • vue-typer Not an option until Vue3 support is implemented, which may never happen since it seems the project has not been updated since 2017
@Kuenaimaku
Copy link
Owner

I think going with the typeit implementation would probably be for the best, and I can look into it this weekend, unless you have the capacity to work on it earlier.

@Kuenaimaku Kuenaimaku added the bug Something isn't working label Sep 19, 2022
@OmnesPotens
Copy link
Author

I think going with the typeit implementation would probably be for the best, and I can look into it this weekend, unless you have the capacity to work on it earlier.

I likely won't get a chance this week unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants