Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Last visit date: Today" in profilebox #2301

Closed
sozzled opened this issue Feb 18, 2014 · 22 comments
Closed

"Last visit date: Today" in profilebox #2301

sozzled opened this issue Feb 18, 2014 · 22 comments
Labels
Milestone

Comments

@sozzled
Copy link

sozzled commented Feb 18, 2014

This issue is discussed in http://www.kunena.org/forum/k-3-0-general-questions/129951-last-visit-date-is-always-today

The last visit date will always be today. Therefore, this information is totally meaningless and the line should be removed from K 3.0 and K 3.1

@coder4life
Copy link
Contributor

I think we have a funky parameter or function there. It seems to work in the profile section.

@sozzled
Copy link
Author

sozzled commented Feb 21, 2014

The last visit date in the profilebox is a little meaningless unless the site administrator allows for very long Joomla sessions. For example, if a site administrator allows for a Joomla session length of 50000 minutes and if a user logs in but does not explicitly logout for over a month, then the "last visit date" may have some "value" because it will display the date when the user logged in. But, because the standard Joomla session length is only 15 minutes and because it is not considered a good practice to allow excessively long sessions, the possibility that the last visit date may have some value as something to display in the profilebox would be unlikely.

There is also another (remotely likely) possibility that, if a user was somehow able to interact with the website continuously around the clock (and never be logged out due to inactivity) then the last visit date may have some "value".

In my opinion, displaying the last visit date in the profilebox has very little instrinsic "value" except, perhaps, in the tiny percentage of cases where users can remain logged in to a site for days or weeks on end.

@rich20
Copy link
Member

rich20 commented Feb 22, 2014

There are two different informations. It's only the last visit date in the profilebox wrong. But in the profile is the date of the last login correct. Then it can have nothing to do with the Joomla session length.

@810
Copy link
Member

810 commented Feb 22, 2014

@rich20 can you try this with K3.1, i can't see the issue there.

@rich20
Copy link
Member

rich20 commented Feb 22, 2014

In Crypsis is it vice versa. I think, the error is in the templates present.
Here you can see the profiles blue eagle and crypsis.
text4591

xillibit added a commit to xillibit/Kunena-forum that referenced this issue Feb 22, 2014
@rich20
Copy link
Member

rich20 commented Feb 23, 2014

I think, in crypsis it's correct now. In the profilebox is the date of the last login and in the profile is the current login time.

@xillibit
Copy link
Member

I will backport this fix into k3.0.x later

mahagr added a commit that referenced this issue Feb 25, 2014
 "Last visit date: Today" in profilebox #2301
@mahagr mahagr added this to the 3.1.0 milestone Feb 25, 2014
@rich20
Copy link
Member

rich20 commented Feb 25, 2014

Is fixed in Crypsis

@rich20
Copy link
Member

rich20 commented Mar 2, 2014

I will backport this fix into k3.0.x later

Should remain here still open?

@xillibit
Copy link
Member

xillibit commented Mar 2, 2014

I had forgot to create a PR for that for K3.0, i will do that now

xillibit added a commit to xillibit/Kunena-forum that referenced this issue Mar 2, 2014
@xillibit
Copy link
Member

xillibit commented Mar 2, 2014

@rich20 : can-you try in this fix in K3.0 ?

@rich20
Copy link
Member

rich20 commented Mar 2, 2014

In the loginbox is the current login time and in the profile the date of the last login. Correctly it would be vice versa.

@xillibit
Copy link
Member

xillibit commented Mar 7, 2014

@rich20 : is-this correct like that:

dsdfs

?

@rich20
Copy link
Member

rich20 commented Mar 8, 2014

In principle it works, but it should be the other way around.

rect4391

xillibit added a commit to xillibit/Kunena-forum that referenced this issue Mar 8, 2014
@xillibit
Copy link
Member

xillibit commented Mar 8, 2014

@rich20 : can-you try now ?

@rich20
Copy link
Member

rich20 commented Mar 8, 2014

Now it's again as at the beginning. In the profilebox is always "Today"
and in the profile the date of the last visit.

@810
Copy link
Member

810 commented May 7, 2014

  • Profilebox showed always "Today" Blue Eagle
  • Profile info showed correct time "Today" Blue Eagle
  • Profile info showed correct time "Today" Crypsis

@810
Copy link
Member

810 commented May 8, 2014

@xillibit the thing is that there are 2 different times. The profile showed the correct time, in the logout is the time from when login. not from the last time. I can't see the issue. not in view or in lib.

coder4life added a commit that referenced this issue May 11, 2014
"Last visit date: Today" in profilebox #2301
@mahagr
Copy link
Member

mahagr commented May 27, 2014

Any conclusions on this one?

@rich20
Copy link
Member

rich20 commented May 27, 2014

It's correct in Blue Eagle now.
In the login box is "Last login" (with current login time)
in the profile is "Last visit date"
both are correct.

But in Crypsis there's only the last login time. In the login box as well as in the profile.

@810
Copy link
Member

810 commented Jun 1, 2014

Can be closed.

On crypsis I changed it to last login. And its merged

@sozzled
Copy link
Author

sozzled commented Jun 2, 2014

I understand that this will be included in K 3.0.6 (expected to be released around the same time as K 3.1 beta).

@sozzled sozzled closed this as completed Jun 2, 2014
@mahagr mahagr removed the fixed? label Jun 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants