Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-reply and require email error #3533

Closed
Ruud68 opened this issue Nov 16, 2015 · 7 comments
Closed

quick-reply and require email error #3533

Ruud68 opened this issue Nov 16, 2015 · 7 comments
Labels
Milestone

Comments

@Ruud68
Copy link
Contributor

Ruud68 commented Nov 16, 2015

Hi,
yesterday I noticed that the fix for adding the email field to the quick reply is not fully working :(
It works correct for quests, but when logged in the email is also required, this should not be.

banging my head against the wall for having tested this to quickly.

anyway, the fix is in components/com_kunena/template/crypsis/layouts/message/edit/quickreply.php

replace

<?php if ($config->askemail): ?>

with

<?php if ($config->askemail && !$me->exists()): ?>
@xillibit
Copy link
Member

At which line did-you seen that ? Because it already check if the user doesn't exist

@Ruud68
Copy link
Contributor Author

Ruud68 commented Nov 17, 2015

Hi, as you can see here, it does check for user logged in, but the display of the emailfield is outside that if statement...

                        <?php if (!$me->exists()) : ?>
                                <div class="controls">
                                        <label>
                                                <?php echo JText::_('COM_KUNENA_GEN_NAME'); ?>:
                                        </label>
                                        <input type="text" name="authorname" class="span12" maxlength="35" placeholder="<?php echo JText::_('COM_KUNE$
                                </div>
                        <?php endif; ?>

                        <?php if ($config->askemail): ?>
                                <div class="controls">
                                        <?php echo $config->showemail == '0' ? JText::_('COM_KUNENA_POST_EMAIL_NEVER') : JText::_('COM_KUNENA_POST_EM$
                                        <input type="text" id="email" name="email" placeholder="<?php echo JText::_('COM_KUNENA_TOPIC_EDIT_PLACEHOLDE$
                                </div>
                        <?php endif; ?>
'''

@xillibit
Copy link
Member

I see now the line that you are mentionning, i will fix it later

@xillibit xillibit added bug and removed unconfirmed labels Nov 17, 2015
xillibit added a commit to xillibit/Kunena-forum that referenced this issue Nov 17, 2015
@810 810 added this to the 4.0.8 milestone Nov 17, 2015
@810
Copy link
Member

810 commented Nov 18, 2015

I had removed it because in the description its said also for registered users.

"Require an e-mail address when users or visitors make a post" That's why I removed it

@Ruud68
Copy link
Contributor Author

Ruud68 commented Nov 18, 2015

hi, I was/am under the assumption that a user always has an email address (as part of the registration process), so asking for the email address is only applicable to guests. Correct?
If so, the above mentioned description should be changed to: "Require an e-mail address when visitors make a post"

@xillibit
Copy link
Member

We know email for registered users so yes the sentence above isn't correct i think

810 added a commit that referenced this issue Dec 1, 2015
quick-reply and require email error #3533
@810
Copy link
Member

810 commented Dec 1, 2015

ok merged.

@810 810 closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants