New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu on mobile broken due to depency login #6131

Closed
Ruud68 opened this Issue Oct 15, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@Ruud68
Contributor

Ruud68 commented Oct 15, 2018

Describe the bug
when looking at the forum from a mobile device, the menu bar is 'empty'.

To Reproduce
Steps to reproduce the behavior:

  1. Go to kunen plugin: Kunena - Joomla Integration
  2. Set 'Enable Joomla login' to: No
  3. goto the forum on the front-end on your desktop: the menu is visible
  4. switch to mobile view: the menu is removed

Expected behavior
The menu bar should have the left-side 'hamburger' dropdown menu

Actual result
the left side hamburger menu is not rendered

Screenshots
Desktop:
image

Mobile:
image

System information (please complete the following information)

Joomla version: 3.8.13
Kunena version: 5.1.5 (and earlier)
Php version: 7.1.x
Database version: mysql 5.6.x

Additional information
when setting the enable joomla login to yes, the menu (and the login button is shown as you can see. But these two are not related! so should not be dependent on each other
image

@xillibit xillibit added bug 5.1 labels Oct 20, 2018

@xillibit xillibit added this to the 5.1.6 milestone Oct 20, 2018

@810

This comment has been minimized.

Member

810 commented Nov 7, 2018

Mhh I can see the menu on mobile when I disable the kunena - Joomla login option

image

@Ruud68

This comment has been minimized.

Contributor

Ruud68 commented Nov 8, 2018

I'm confident that this is not possible (when looking at the code), it should only shown when the plugin "Kunena - Joomla Integration" has " Enable Joomla Login" set to yes.

the crypsis menubar widget, displays the "desktop-visible" and then triggers the "Widget/Login" (via subRequest('Widget/Login'); ?>)

the Widget/Login 'bails' when login is disabled in plugin:
./controller/widget/login/display.php

                $login = KunenaLogin::getInstance();

                if (!$login->enabled())
                {
                        return false;
                }

so that only displays the login menu when the plugin is set to login = yes.
the mobile hamburger menu is part of the login / lougout widget!

Just install 5.1.6dev2 to rule out if that makes a difference.
I will email you the credentials and link to my test site. Maybe you can sport the setting that does the magic'

@810

This comment has been minimized.

Member

810 commented Nov 8, 2018

it was working until I saved the Kunena - Kunena Integration plugin.

@810 810 closed this Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment