Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick icon update notification not 'translated' #9165

Closed
Ruud68 opened this issue Jul 11, 2022 · 3 comments · Fixed by #9180
Closed

quick icon update notification not 'translated' #9165

Ruud68 opened this issue Jul 11, 2022 · 3 comments · Fixed by #9180
Labels
bug Language
Milestone
6.0

Comments

@Ruud68
Copy link
Contributor

Ruud68 commented Jul 11, 2022

Describe the bug
Selection_001

Expected behavior
it should say that update is available

Actual result
language string displayed

Joomla version: 4.1.5
Kunena version: 6.0.1 (with update available for 6.0.1.1)
@rich20 rich20 added this to the 6.0 milestone Jul 11, 2022
@rich20
Copy link
Member

rich20 commented Jul 11, 2022 •
edited

The string is correctly present in the language folder of the plugin, but is not displayed. This string is displayed only if it is included in the com_kunena.sys.ini backend file.
So we should add this string to backend com_kunena.sys.ini:
PLG_QUICKICON_KUNENA_UPDATE_NOW = "Update now!"

@xillibit
Copy link
Member

we may have the same issue with others strings :

PLG_QUICKICON_KUNENA_UPDATE_ADDONS = "Update %d add-ons!"
PLG_QUICKICON_KUNENA_UPDATE_NOW = "Update now!"
PLG_QUICKICON_KUNENA_UPDATE_DISABLED = "Updates disabled"
PLG_QUICKICON_KUNENA_COMPLETE_INSTALLATION = "Please complete Kunena installation!"

xillibit added a commit to xillibit/Kunena-forum that referenced this issue Jul 14, 2022
@xillibit
[K6.0] quick icon update notification not 'translated' Kunena#9165
2610254
@xillibit xillibit mentioned this issue Jul 14, 2022
Merged
xillibit added a commit that referenced this issue Jul 14, 2022
@xillibit
[K6.0] quick icon update notification not 'translated' #9165 (#9167)
50aac56
@rich20
Copy link
Member

rich20 commented Jul 16, 2022

we may have the same issue with others strings :

Yes, that is probably possible. Maybe you should add all 4 strings to the kunena.sys.ini.

xillibit added a commit to xillibit/Kunena-forum that referenced this issue Jul 30, 2022
@xillibit
[K6.0]Quick icon update notification not translated(move strings) Kun…
8dbfd28 
…ena#9165
@xillibit xillibit mentioned this issue Jul 30, 2022
Merged
xillibit added a commit that referenced this issue Jul 30, 2022
@xillibit
[K6.0]Quick icon update notification not translated(move strings) #9165…
cb09e8f 
… (#9180)
xillibit added a commit that referenced this issue Aug 5, 2022
@xillibit
[K6.0] quick icon update notification not 'translated' #9165 (#9167)
902926e
xillibit added a commit that referenced this issue Aug 5, 2022
@xillibit
[K6.0]Quick icon update notification not translated(move strings) #9165…
c2331bb 
… (#9180)
xillibit added a commit that referenced this issue Aug 5, 2022
@xillibit @810
[K6.1] Merge last changes from K6.0 (#9193)
30257a4 
* [Composer] Update config

* [Composer] Update config

* [Composer] Update config

* [K6.0] Some codestyle on kunena.php file in plg_finder_kunena (#9160)

* [K6.0] Bat script broken to make symbolic links (#9163)

* [K6.0] PHP 8.1 - hints for Deprecated strings #9162 (#9164)

* [K6.0] json_decode():Passing null #1 InstallerScript.php line 322 #9158

* [K6.0] json_decode():Passing null #1 InstallerScript.php (Part 2) #9158 (#9166)

* [K6.0] Port some changes from K5.2.9

* [K6.0] quick icon update notification not 'translated' #9165 (#9167)

* [K6.0] Prevent to load Kunena system plugin if it's in Cli mode (#9168)

* [K6.0] PHP 8.1/Announcement Automatic conversion false to array #9169 (#9171)

* [K6.0]Deprecated:str_replace():Passing null to parameter of type array

* [K6.0] Update CKeditor to 4.19.1 (#9172)

* Update composer

* [K6.0] Port fix from K5.2 on RSS timelimit and change setting on update (#9178)

* [K6.0] Remove test template files (#9179)

* [K6.0]Quick icon update notification not translated(move strings) #9165 (#9180)

* [K6.0] Error "View not found" when opening RSS feed (#9181)

* [K6.0] Prevent to drag and drop images directly in CKeditor area (#9182)

* [K6.0] Make working RSS settings : recent and topics (#9184)

* [K6.0] Add fix from K5.2 on RSS (#9186)

* [K6.0] The exist status of an user was wrong, new user wasn't added in (#9187)

* [K6.0]Backend -> Edit user: Save button works same as Save & Close #9191 (#9192)

Co-authored-by: Jelle Kok <schumacher1986@hotmail.com>
xillibit added a commit that referenced this issue Aug 5, 2022
@xillibit
[K6.0] quick icon update notification not 'translated' #9165 (#9167)
bcef7ed
xillibit added a commit that referenced this issue Aug 5, 2022
@xillibit
[K6.0]Quick icon update notification not translated(move strings) #9165…
560401e 
… (#9180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Language
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

[K6.0]Quick icon update notification not translated(move strings) #9165 xillibit/Kunena-forum
3 participants
@xillibit @rich20 @Ruud68