New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfiniteScroll: add missing tbody and tbody classes #6164

Merged
merged 1 commit into from Nov 25, 2018

Conversation

Projects
None yet
2 participants
@Ruud68
Copy link
Contributor

Ruud68 commented Nov 22, 2018

Hi, working on Infinite Scroll functionality for Kunena. Infinite Scroll will replace the 'pagination' and when there are multiple pages, they will automatically load and append to the page.

For this to work, the infinite-scroll script needs to be able to identify the container where the rows reside and where the loaded rows will be appended.

Identifying the 'container' works via a class name.

Summary of Changes

add missing to ./category/item/default.php
add class names on tags for list views that use pagination

Testing Instructions

Here you can see it working (note: work in progress) :)
https://office.onlinecommunityhub.nl/och_test/forum/jssocials

@Ruud68 Ruud68 changed the title add missing tbody and tbody classes InfiniteScroll: add missing tbody and tbody classes Nov 22, 2018

@810

This comment has been minimized.

Copy link
Member

810 commented Nov 25, 2018

Hi, please do new features on the K6.0 branch

@810 810 merged commit e2ae171 into Kunena:K5.1 Nov 25, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Ruud68

This comment has been minimized.

Copy link
Contributor

Ruud68 commented Nov 25, 2018

here you go: #6166

@Ruud68 Ruud68 deleted the Ruud68:infinitescrollable branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment