Refactoring Mobile user menu #9308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Pfister <pfister@contria.com>
* add dropstart on mobile view * add dropstart on user menu
|
I had rebased the branch K6.0 to rename some commits, becaus the commit message should start whith [K6.0] if it's on K6.0 branch. Is-it possible that you restart by pulling K6.0 and delete the existing K6.0 ? |
fotofreunde
reviewed
Oct 17, 2022
| @@ -12,26 +12,29 @@ | |||
|
|
|||
| defined('_JEXEC') or die(); | |||
|
|
|||
| use Kunena\Forum\Libraries\Icons\KunenaIcons; | |||
| use Joomla\CMS\Language\Text; | |||
|
|
|||
| ?> | |||
|
|
|||
There was a problem hiding this comment.
Hi!
I do not know what I'm doing wrong ;)
If I change that, I'll lose my registration. Everything is moved to left side.
|
Many more files have been changed. I have replied to you in the forum. https://www.kunena.org/forum/36-German/166363-anmeldung-und-darstellungsprobleme-aurelia-vorlage-kunena-6-0-2#226026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #9306 #9299 replacement for #9300 .
Summary of Changes
The way the Kunena menu is implemented is not conform BS5 best practises: the menu has two parts a collapse part with the menu items in it, and the part where the login / logout button is displayed.
It turns out that when the menu is collapsed, not only the collapsed menu is in the collapse, but also the login / logout buttons, these are also still shown on the main (non-collapsed) menu bar.
I have been trying to fix that but this was not possible. I have now refactored the menu to a offcanvas menu.
it turns out that the offcanvas part is more strict: it doesn't display the login / logout buttons: this is exactly what we want.
An IMO it also looks better :)
this PR also contans the fix that login in on the mobile menu (dropdown) wasn't possible (the username field was set as email instead of text input).
Testing Instructions
on device type mobile, tablet, desktop test if login / login toggles the dropdown and if login / logout via dropdown works.
on mobile and tablet test if offcanvas menu shows / hides, test if all menu items also work.
test if dropdown for login / logout are always in the viewport (and not partially offscreen)
cc @rich20