Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: refactored modals not working correct #9647

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

Ruud68
Copy link
Contributor

@Ruud68 Ruud68 commented Mar 6, 2024

Pull Request for Issue # #9646.

Summary of Changes

the following refactored to 4.4 modals where not sumbitting data / form correct:

  • logs > clean
  • users > moderators
  • users - subscribecategories
  • categories > batchmove

Testing Instructions

test not only if modals work (they actually show), but if submitting / processing also works

@xillibit xillibit added this to the 6.3 milestone Mar 6, 2024
@xillibit
Copy link
Member

xillibit commented Mar 6, 2024

  • users > moderators

  • users - subscribecategories

Tested on Joomla! 4.4, when submit the modal it does nothing

  • categories > batchmove

image

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 6, 2024

@xillibit let me check that tomorrow

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 6, 2024

Ok, I'm sure I tested all (except the category batch one): go figure.
Same issue as with some other controller method names: batchCategories method is the same as var in view / model. Somehow PHP / Joomla doesn't like this any more.
So renamed the method to all lowercase and now it works.

presuming this was the only modal not working, this should now be okay.

Updated this PR with new commit

@Ruud68
Copy link
Contributor Author

Ruud68 commented Mar 6, 2024

Ok, just did a test and now the controller method is called okay. But now it is saying that I forgot to select a target category.

Turnout that the controller is getting the selected category from a field on the form that doesn't exist (and also didn't exist in K6.2 so this never worked?).
Anyway, did a last small change (in this PR) and should be working now.
Can you test @xillibit ?

@xillibit
Copy link
Member

xillibit commented Mar 6, 2024

There was two options in the categories batch one have never worked, so i have removed part in the template

@xillibit xillibit merged commit 225b019 into Kunena:K6.3 Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants