Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: refactor plugin modals to dialogs to workaround J5.1 bug #9672

Merged
merged 2 commits into from Apr 18, 2024

Conversation

Ruud68
Copy link
Contributor

@Ruud68 Ruud68 commented Apr 18, 2024

Pull Request for Issue #9670 .

Summary of Changes

added new J5.1 dialogs when Joomla version is 5.1

Testing Instructions

test on both J5.1 and < J5.1

  1. in back-end goto Kunena > plugins
  2. click a plugin name

on J5.1 a dialog modal should open (save / save& close / close buttons on top
on < J5.1 a BS modal should open (buttons in the footer)

  1. test if all buttons work.

The J5.1 plugin dialog modal is missing the Toggle inline help button (the BS modal has that button in the footer).
I have crated a PR for that in the Joomla repository: appreciate if you could also test that and if okay report back as positive test result on the Joomla repository: joomla/joomla-cms#43296

@xillibit
Copy link
Member

It-is need to apply the PR4326 from Joomla! to test it ?

@Ruud68
Copy link
Contributor Author

Ruud68 commented Apr 18, 2024

It-is need to apply the PR4326 from Joomla! to test it ?

No, not needed.
It should work without the Joomla PR.

The Joomla PR adds the button 'Toggle inline help' that is missing in the new 5.1 dialog modal.
You can test that separately if you have time and energy to do so :)

@xillibit xillibit merged commit 46d1f80 into Kunena:K6.3 Apr 18, 2024
4 checks passed
@Ruud68 Ruud68 deleted the pluginmodals branch April 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants