Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument restoration is not working correctly when instrument parameters are modified during initialization of the instrument #165

Closed
KungFuFurby opened this issue Jun 5, 2021 · 0 comments · Fixed by #166
Closed

Instrument restoration is not working correctly when instrument parameters are modified during initialization of the instrument #165

KungFuFurby opened this issue Jun 5, 2021 · 0 comments · Fixed by #166
Labels
bug Something isn't working spc-side Involves the SPC700 code.
Projects
AddMusicK 1.0.9? Merge TODO List

Comments

@KungFuFurby
Copy link
Owner

Reported by Anas on the SNESLab server.

In the middle of an instrument change, if additional parameters are modified afterwards (most commonly the ADSR), it causes the instrument restoration to fail with incomplete settings having been stored in the backup table.

Related to #143. However, I'm not sure about #143's relevance... because the backup SRCN ID is required to resolve #143. Since only one music noise frequency is supported, the fix could end up killing two birds with one stone.
@KungFuFurby KungFuFurby added bug Something isn't working spc-side Involves the SPC700 code. labels Jun 5, 2021
KungFuFurby added a commit that referenced this issue Jun 5, 2021
@KungFuFurby
Unconditionally compile instrument backup table on setup
1f0079e 
Restorations can fail if the instrument table is not set up due to SFX
interference and then the table gets modified, causing the restoration to be
incomplete and containing previous parameters instead.

This commit closes #165 and closes #143.
This was referenced Jun 5, 2021
Merged
Merged
AddMusicK 1.0.9? Merge TODO List automation moved this from In progress to Done Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working spc-side Involves the SPC700 code.
Projects
No open projects
AddMusicK 1.0.9? Merge TODO List
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unconditionally compile instrument backup table on setup KungFuFurby/AddMusicKFF
1 participant
@KungFuFurby