Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Codec's AMK Beta (parser version 3) #282

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Commits on Apr 6, 2022

  1. Update AddmusicK Parser Version to 3 for this branch

    This marks the beginning of the implementation for Codec's AddmusicK Beta. Note
    that the upcoming code will be sourced, though also probably slightly modified,
    from the C++ source, which is otherwise not public, unlike the rest of the
    extant beta: I acquired the source from Codec themselves.
    
    This branch will not be merged until all of the music changes are implemented.
    
    This commit mentions #216.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3da5cc7 View commit details
    Browse the repository at this point in the history
  2. Add fade support for global volume through the w command

    Mostly adapted from the source for Codec's AMK beta, though with some minor
    adjustments.
    
    This commit mentions #216.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    cbcf15e View commit details
    Browse the repository at this point in the history
  3. Add fade support for volume through the v command

    Mostly adapted from the source for Codec's AMK beta, though with some minor
    adjustments.
    
    This commit mentions #216.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    81a3831 View commit details
    Browse the repository at this point in the history
  4. Add fade support for tempo through the t command

    Mostly adapted from the source for Codec's AMK beta, though with some minor
    adjustments.
    
    This commit mentions #216.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1fd624c View commit details
    Browse the repository at this point in the history
  5. Partially add support for remote code reset directive (!!)

    Pretty much directly adapted from the source for Codec's AMK beta, though with
    some minor adjustments.
    
    Resetting key on and non-key on remote code events are not yet implemented.
    Technically they can be since I have them in another branch, but that still
    requires some inheritance, so to speak.
    
    This commit mentions #216.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    cde0f8a View commit details
    Browse the repository at this point in the history
  6. Add unimplemented notices for all remaining features on the TODO list

    Some of these require new hex commands or SPC700-side code. Others, well... they
    simply haven't been implemented yet.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    759cefd View commit details
    Browse the repository at this point in the history
  7. Replace switch within a switch with if/else if chain

    My bad for this failed circumnavigation (and not thinking things through with
    using make on this before pushing).
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    60afe2c View commit details
    Browse the repository at this point in the history
  8. Accidentally missed a line in tempo fade MML adaptation

    This one stops the parser from guessing the tempo, as it already does not guess
    when any tempo fade is used.
    KungFuFurby committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5bdd2d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Configuration menu
    Copy the full SHA
    a70009a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Correction to tempo processing

    An erroneous text position increment was added on where it wasn't supposed to be
    since it was already done, causing one of the digits to not get read correctly.
    KungFuFurby committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    ed269da View commit details
    Browse the repository at this point in the history
  2. Correct a bug with using the wrong variable reference for a zero temp…

    …o check
    
    The source code I got made a mistake with testing with ltempo, when ltempo was
    not the variable that was supposed to be checked. Also, AddmusicK used a tabbed
    block without using brackets, which for me is more Python-esque than C++-esque.
    KungFuFurby committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    675ef1f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Correct a bad adaptation of w and v commands

    A bad variable reference was used, and the v commands were outputting the wrong
    values.
    KungFuFurby committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    e8b9d45 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Configuration menu
    Copy the full SHA
    49122f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Implement all remote code reset types in MML for Codec's AMK Beta

    With the addition of the two remote code events tailored for the two types of
    events, the implementation of (!!) can be completed on a technicality.
    KungFuFurby committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    1605ffc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ca6e38 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7870b1b View commit details
    Browse the repository at this point in the history
  4. Allow (!!) in parser versions 3 and up

    (!!) was initially not going to be implemented in parser version 4 due to me not
    wanting to grab anything that required a new hex command. However, due to the
    way AMK Beta's Remote Gain was restored, this MML command can now make the cut
    into parser version 3.
    
    : and % are still cut from parser version 4, on that note: : because it requires
    a new hex command, and % because of a conflict with binary notation in asar (I
    have decided to reserve this for parsing a binary number).
    KungFuFurby committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    fbb2506 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Configuration menu
    Copy the full SHA
    f831374 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69231f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Configuration menu
    Copy the full SHA
    a894f0d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Configuration menu
    Copy the full SHA
    dc25344 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Configuration menu
    Copy the full SHA
    b0c7a01 View commit details
    Browse the repository at this point in the history
  2. Add changelog entry for adding Codec's AddmusicK Beta support

    Partially cherry picked off of commit e026687 .
    Does not include components that currently require a different commit to
    implement.
    KungFuFurby committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    63c4e31 View commit details
    Browse the repository at this point in the history
  3. Corrected a bad merge

    Didn't realize a marker was removed in the process of merging, which would have
    caused a compilation failure.
    KungFuFurby committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    7469eb8 View commit details
    Browse the repository at this point in the history