Simple refactoring on core #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all, thank you so much for your contribution. It is really important for us :) |
| @@ -20,10 +20,9 @@ def Setting.create | |||
| @@settings = new unless @@settings | |||
| return @@settings | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Take care with white space.
There was a problem hiding this comment.
Sorry about that, I deletes the comment bellow and I put back again thinking it would be useful
Show error exception cause Refactoring methods set_configuration Breaking line with the number of characters exceeded Remove white spaces
|
@pwener it is ok your PR, I just have two observations:
|
|
I'm failing to use squash, I will try to redo the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
initializate_settingscan't receive params to set@configurationInfo?