Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bin #213

Merged
merged 9 commits into from
Apr 27, 2017
Merged

Refactor bin #213

merged 9 commits into from
Apr 27, 2017

Conversation

lucaskanashiro
Copy link
Contributor

This PR closes an architectural issue: #205

This tests were written in ShellScript and now we depends on shunit2
* rake test:unit -> run unit tests
* rake test:acceptance -> run acceptance tests
* rake test:all -> run all tests, for while unit and acceptance tests
Install shunit2 and run unit and acceptance tests
Copy link
Member

@rodrigosiqueira rodrigosiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, some points:

  1. With this pull we have the new dependencies: shunit2 and mispipe. Please, add it to README.
  2. Just take a look at the end of some files, because it has some extra spaces

Great Job!

output=`bin/kuniri $file`
diff expected_result.xml outputKuniri.xml
assertEquals 0 "$?"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space at the end (vim -> set list)

output=`bin/kuniri $file -fake`
contains "$output" "invalid option"
assertEquals 0 "$?"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space at the end (vim -> set list)

@rodrigosiqueira rodrigosiqueira merged commit 0f4cace into Kuniri:dev Apr 27, 2017
@lucaskanashiro lucaskanashiro deleted the refactor_bin branch April 27, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants