-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor bin #213
Refactor bin #213
Conversation
Closes Kuniri#205
This tests were written in ShellScript and now we depends on shunit2
* rake test:unit -> run unit tests * rake test:acceptance -> run acceptance tests * rake test:all -> run all tests, for while unit and acceptance tests
Install shunit2 and run unit and acceptance tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done, some points:
- With this pull we have the new dependencies: shunit2 and mispipe. Please, add it to README.
- Just take a look at the end of some files, because it has some extra spaces
Great Job!
tests/cli_test.sh
Outdated
output=`bin/kuniri $file` | ||
diff expected_result.xml outputKuniri.xml | ||
assertEquals 0 "$?" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space at the end (vim -> set list)
tests/cli_test.sh
Outdated
output=`bin/kuniri $file -fake` | ||
contains "$output" "invalid option" | ||
assertEquals 0 "$?" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space at the end (vim -> set list)
This PR closes an architectural issue: #205