Language refactoring #217
Merged
Language refactoring #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file ruby_syntax.rb the issue raised by rubocop on initialize method does not make any sense. This method just initialize parameters, thus we prefer increase the accepted AbcSize metric. Closes Kuniri#208 Signed-off-by: Lucas Kanashiro <kanashiro@debian.org> Signed-off-by: Bruno Sesso <bruno.sesso@usp.br> Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br>
Closes Kuniri#209 Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br> Signed-off-by: Lucas Kanashiro <kanashiro@debian.org>
Due to modifications in line_inspect method, @methodHandler.method(:get_method) raises NameError exception because @methodHandler is nil. Before this change, @methoHandler.get_method(pLine) raised a NoMethodError because nilClass do not have this method. Since the reasons are the same, the changes are valid. Signed-off-by: Lucas Kanashiro <kanashiro.debian.org> Signed-off-by: Giuliano Belinassi <giuliano.belinassi@usp.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring language.rb closes #209