-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy: double quote: allow if dollar in string #340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 133 133
Lines 4155 4155
Branches 417 417
=======================================
Hits 3893 3893
Misses 167 167
Partials 95 95 |
Thank you! |
Well thank you. Awesome plugin (I'm using it with vim's ale) ! Fast merge, congrat. |
@tinmarino |
ah, wait. I think this change is unnecessary because above two expressions are evaluated to the same results. |
True, missed that. |
Hi guys. Tk @tyru !! Actually I was missing something. My PR is an error, my bad : the echo "$HOME" " -> $HOME
echo '$HOME' " -> $HOME Sorry for that. |
One line to allow double quotes if there is a dollar in the string.
As example from my vimrc:
Cleaner than
$h . '/wiki/wiki'
in my opignon