Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Fix the http location issue once for all. #88

Merged
merged 1 commit into from Feb 19, 2021

Conversation

PabloMK7
Copy link

@PabloMK7 PabloMK7 commented Feb 12, 2021

The http header names are not case sensitive, so they kept changing and breaking the app. This fixes the issue once for all by converting both the input name and the header name to lowercase.

From: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive. The field value MAY be preceded by any amount of LWS, though a single SP is preferred.

@kittenchilly
Copy link

Could you upload a CIA file for this updated version here so I don't have to fiddle with compiling it myself? Doesn't look like Kunoichi is interested in updating the main repo either.

@TheGoofBall64
Copy link

yeah. if you could upload a CIA that would be great

@PabloMK7
Copy link
Author

I will wait a few days for @KunoichiZ to confirm or deny they will do the update. Otherwise I'll have to update the repo links and build the cia myself.

@KunoichiZ KunoichiZ merged commit ff57852 into KunoichiZ:master Feb 19, 2021
@Trainax
Copy link

Trainax commented Mar 7, 2021

Hi @mariohackandglitch. Sorry to bother you. I tried following the instructions in the README file to complile the cia file myself, however I keep getting errors when lauching the make command.

Could you please make a tutorial on what to install from zero to compile this?

I used devkitPro pacman and I included makerom and bannertool in my PATH environment however how hard I try it doesn't find the correct libraries.

immagine

Thank you very much

@KunoichiZ
Copy link
Owner

@Trainax Don't bother, I'm working on it myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants