[AllBundles] Deprecate unused controller actions and document method …

…visibility changes (#1883)

UPGRADE-5.1.md

@@ -16,19 +16,26 @@ ArticleBundle
 -------------
 
  * Passing the `request_stack` service as the third argument in `Kunstmaan\ArticleBundle\Twig\ArticleTwigExtension` is deprecated and will be removed in 6.0.
+ * The `getAdminListConfigurator` and `createAdminListConfigurator` method in the `AbstractArticleEntityAdminListController` class will change from `public` to `protected` visibility in 6.0.
 
 ConfigBundle
 ------------
 
  * Passing the `container` as the sixth argument in `Kunstmaan\ConfigBundle\Controller\ConfigController` is deprecated in and will be removed in 6.0.
 
+MediaBundle
+-----------
+
+ * The unused `MediaController::moveMedia` action is deprecated and will be removed in 6.0.
+
 NodeBundle
 ----------
 
  * `CronUpdateNodeCommand::__construct()` now takes an instance of `Doctrine\ORM\EntityManagerInterface` as the first argument. Not passing it is deprecated and will throw a `TypeError` in 6.0.
  * `InitAclCommand::__construct()` now takes an instance of `Doctrine\ORM\EntityManagerInterface` as the first argument. Not passing it is deprecated and will throw a `TypeError` in 6.0.
  * `CronUpdateNodeCommand` and `InitAclCommand` have been marked as final.
- * `Possibility to change the icon of your page.`: The possibility already exists to change the icon in the sidebar tree of your page. This was already available by yml configuration. I've added a new interface, TreeIconInterface that can be implemented and that will return the icon that should be used. 
+ * `Possibility to change the icon of your page.`: The possibility already exists to change the icon in the sidebar tree of your page. This was already available by yml configuration. I've added a new interface, TreeIconInterface that can be implemented and that will return the icon that should be used.
+ * The unused `WidgetsController::selectNodesLazySearch` action is deprecated and will be removed in 6.0. 
 
 TranslatorBundle
 ----------------

src/Kunstmaan/ArticleBundle/Controller/AbstractArticleEntityAdminListController.php

@@ -41,6 +41,8 @@ abstract class AbstractArticleEntityAdminListController extends AdminListControl
     protected $aclHelper;
 
     /**
+     * NEXT_MAJOR: change method visibility from public to protected
+     *
      * @return AdminListConfiguratorInterface
      */
     public function getAdminListConfigurator(Request $request)
@@ -54,6 +56,8 @@ public function getAdminListConfigurator(Request $request)
     }
 
     /**
+     * NEXT_MAJOR: change method visibility from public to protected
+     *
      * @return AbstractArticlePageAdminListConfigurator
      */
     abstract public function createAdminListConfigurator();

src/Kunstmaan/MediaBundle/Controller/MediaController.php

@@ -454,6 +454,8 @@ public function createModalAction(Request $request, $folderId, $type)
      */
     public function moveMedia(Request $request)
     {
+        @trigger_error(sprintf('The "%s" controller action is deprecated in KunstmaanMediaBundle 5.1 and will be removed in KunstmaanMediaBundle 6.0.', __METHOD__), E_USER_DEPRECATED);
+
         $mediaId = $request->request->get('mediaId');
         $folderId = $request->request->get('folderId');
 

src/Kunstmaan/NodeBundle/Controller/WidgetsController.php

@@ -63,6 +63,8 @@ public function selectLinkAction(Request $request)
      */
     public function selectNodesLazySearch(Request $request)
     {
+        @trigger_error(sprintf('The "%s" controller action is deprecated in KunstmaanNodeBundle 5.1 and will be removed in KunstmaanNodeBundle 6.0.', __METHOD__), E_USER_DEPRECATED);
+
         /* @var EntityManagerInterface $em */
         $em = $this->getDoctrine()->getManager();
         $locale = $request->getLocale();