[GeneratorBundle]: update menuadaptor to correct syntax #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sandergo90
commented
Feb 24, 2016
sandergo90
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
| } | ||
|
|
||
| public function adaptChildren(MenuBuilder $menu, array &$children, MenuItem $parent = null, Request $request = null) | ||
| { | ||
| $overviewPageNodes = $this->em->getRepository('KunstmaanNodeBundle:Node')->findByRefEntityName('{{ namespace|replace({"\\": "\\\\"}) }}\\Entity\\Pages\\{{ entity_class }}OverviewPage'); | ||
| foreach ($overviewPageNodes as $overviewPageNode) { | ||
| $this->overviewpageIds[] = $overviewPageNode->getId(); |
There was a problem hiding this comment.
The overviewpageIds should be cached in private class variable because the adaptChildren is called multiple times
sandergo90
force-pushed
the
menuadaptor
branch
2 times, most recently
from
d946575
to
eafc62a
Compare
[MenuAdaptor]: fill overviewpageids only once Set overviewpageids to null
jockri
pushed a commit
that referenced
this pull request
Mar 1, 2016
[GeneratorBundle]: update menuadaptor to correct syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.