[ConfigBundle]: add new configuration bundle #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $internal_name | ||
| * @return mixed | ||
| */ | ||
| public function getConfigEntityByInternalName($internal_name) |
sandergo90
force-pushed
the
kuma-configbundle
branch
from
4cc03f2
to
77fc99c
Compare
| /** | ||
| * Generates the site config administration form and fills it with a default value if needed. | ||
| * | ||
| * @Route(path="/", name="KunstmaanConfigBundle_settings_configs") |
There was a problem hiding this comment.
internal_name should be a clean routing parameter not in query string
sandergo90
force-pushed
the
kuma-configbundle
branch
from
77fc99c
to
ca9c7da
Compare
|
|
||
| if ($entity->getInternalName() == $internalName) { | ||
| $repo = $this->em->getRepository($class); | ||
| $config = $repo->findOneBy(array()); |
There was a problem hiding this comment.
For performance, I would store the retrieved config so when get_config is called again for the same internal name it doesn't trigger the query again.
sandergo90
force-pushed
the
kuma-configbundle
branch
from
ca9c7da
to
8f5c60a
Compare
| @@ -0,0 +1,4 @@ | |||
| kunstmaanconfigbundle_default: | |||
| resource: "@KunstmaanConfigBundle/Controller/ConfigController.php" | |||
There was a problem hiding this comment.
Better controller as service, so it is easy to override the controller class if needed
sandergo90
force-pushed
the
kuma-configbundle
branch
from
8f5c60a
to
f70828e
Compare
[ConfigBundle]: cleanup [ConfigBundle]: remarks fixes Save configs into array [ConfigBundle]: change configcontroller to service Adding docs in root
sandergo90
force-pushed
the
kuma-configbundle
branch
from
f70828e
to
aac8d0b
Compare
jockri
pushed a commit
that referenced
this pull request
Mar 8, 2016
[ConfigBundle]: add new configuration bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bundle allows you to create a entity that extends the AbstractConfig class.
By doing this you can create a settings form with some custom configuration variables.