[AdminBundle] Prevent duplicate reinits in same pagepart (reorder) #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dannyvw
commented
Apr 11, 2016
dannyvw
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
|
@diskwriter Can you take a look? |
|
Hi Danny I just noticed there's some duplicate code in this file that shouldn't be there. I've also commented for a small improvement. Thanks in advance |
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| for (var i = 0; i < uniqueModules.length; i++) { | ||
| kunstmaanbundles[uniqueModules[i]].reInit(); |
There was a problem hiding this comment.
No real need for an extra for loop here. You could also reInit the modules in the first for loop.
|
Pull request is updated |
|
Thanks, @dannyvw |
dannyvw
force-pushed
the
bugfix/prevent-reinit-pagepart
branch
from
731e4dc
to
2d2ed24
Compare
|
@diskwriter Done |
|
@dannyvw Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.