[MediaBundle] Added delete confirmation modal when deleting images from media #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dannyvw
commented
Apr 12, 2016
dannyvw
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
|
Hi Danny, You are re-using the modal from the delete folder button. So the confirmation message also says 'Are you sure you want to delete this folder' for files. Can you make the required changes? |
|
We re-use the media delete modal, see screenshot. Please confirm @jockri
|
|
Ok, merged! |
jockri
pushed a commit
that referenced
this pull request
Apr 26, 2016
* master: (29 commits) [NodeBundle]: add group by clause for mysql 5.7 for symfony 2 (#1134) Implement clean deleted media command (#1127) [Global] Translation fix (#1115) Implement missing function (#1123) Fix #1120 bad reference to repository (#1122) [AdminBundle] Auto Google SignIn with Guard (#1119) Fix errors and improve documentation (#1118) Added delete confirmation modal when deleting images from media (#1110) Make remote thumbnails loading with relative protocol (#1114) Added button to clear content media folder (#1112) fire service() method on Page in renderCustomSearchView() (#1108) Update admin translations (#1104) Fixed image cache path (#1100) Move aviary js to own file (#1099) Change admin template extends (#1096) [GeneratorBundle]: change imagepagepart, url's are already absolute [GeneratorBundle] Spaceless fix Move twig extensions Cleanup code test Make admin menu translatable via existing translations ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.