Use relative asset paths in stylesheets and asset() twig function #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a Kunstmaan protect to be run (tested out) from a non-root web path e.g. http://hostname/projects/kunstmaan-project/web/
roderik
pushed a commit
that referenced
this pull request
Jan 23, 2015
Use relative asset paths in stylesheets and asset() twig function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a Kunstmaan protect to be run (tested out) from a non-root web path e.g.
http://hostname/projects/kunstmaan-project/web/There are still some issues with the views in the
MediaBundleandMediaPagePartBundle, these use different ways to render the (image) urls in multiple places:KunstmaanMediaBundle:Media:Image/showKunstmaanMediaPagePartBundle:ImagePagePart:viewKunstmaanGeneratorBundledemosite skeletonSlidePagePart:viewThe simplest way of
src="{{ image.url }}"will also fail, askuma_media.urlcontains a leading slash (e.g./uploads/media/abcde.png)Any ideas what would be the best way to tackle this?
Anyway, I still think these changes will allow people to easier start out developing a project with the KunstmaanBundleCMS without setting up vhosts.