[ArticleBundle] [GeneratorBundle] Add support for tags and categories in ArticleBundle and refactoring of article generator #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
treeleaf
commented
Dec 7, 2016
•
treeleaf
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
treeleaf
force-pushed
the
feature/article-gen
branch
from
8036be2
to
218b1ba
Compare
treeleaf
changed the title
gitis
approved these changes
Dec 9, 2016
Numkil
reviewed
Dec 16, 2016
| } | ||
| $this->routeCollection = new RouteCollection(); | ||
|
|
||
| $extendParameters = array('category' => null, 'tag' => null); |
There was a problem hiding this comment.
Stylistic: phpstorm is nagging me to use the short notation [] as the new way of making arrays
treeleaf
force-pushed
the
feature/article-gen
branch
from
218b1ba
to
33846b7
Compare
treeleaf
force-pushed
the
feature/article-gen
branch
from
33846b7
to
fa70c9a
Compare
… in ArticleBundle and refactoring of article generator
treeleaf
force-pushed
the
feature/article-gen
branch
from
fa70c9a
to
1469fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.