Bugfix for render_pagetemplate() #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tentwofour
commented
Feb 5, 2015
tentwofour
commented
- Merge passed parameters with the current twig context - allows passing of view variables when calling render_pagetemplate()
- Argument was previously unused
|
Not sure if I'm missing another way to do this, but calling render_pagetemplate(page, { 'customVariable': 'myGreatValue' }wasn't passing customVariable to my page template. Not sure why the argument is available, but not merged with the Twig context in the extension - if I'm missing something obvious, let me know :) |
| @@ -72,7 +72,7 @@ public function renderPageTemplate(array $twigContext, HasPageTemplateInterface | |||
|
|
|||
| $template = $this->environment->loadTemplate($pageTemplate->getTemplate()); | |||
|
|
|||
| return $template->render($twigContext); | |||
| return $template->render(array_merge($twigContext, $parameters)); | |||
There was a problem hiding this comment.
It's better to put $parameters as the first element. The keys from the first array will be preserved. If an array key exists in both arrays, then the element from the first array will be used and the matching key's element from the second array will be ignored.
krispypen
added a commit
that referenced
this pull request
Feb 17, 2015
Bugfix for render_pagetemplate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.