Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] Fix the extended ppchooser search for IE11 #1616

Merged
merged 1 commit into from Nov 20, 2017
Merged

[AdminBundle] Fix the extended ppchooser search for IE11 #1616

merged 1 commit into from Nov 20, 2017

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Oct 9, 2017

Searching for pageparts was broken in IE11

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets N/A

diskwriter
diskwriter reviewed Nov 20, 2017
View reviewed changes
Copy link
Contributor

@diskwriter diskwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this against the 4.0 branch, since this is a bugfix please?

@diskwriter diskwriter added this to the 4.0.3 milestone Nov 20, 2017
@Windvis
Copy link
Contributor Author

Windvis commented Nov 20, 2017

The extended pagepart chooser is a new feature in the 5.0 branch.

@diskwriter diskwriter modified the milestones: 4.0.3, 5.0.0 Nov 20, 2017
@diskwriter
Copy link
Contributor

@NindroidX Aha okay, fixed the milestone

@diskwriter diskwriter changed the title Fix the extended ppchooser search for IE11 [AdminBundle] Fix the extended ppchooser search for IE11 Nov 20, 2017
@diskwriter diskwriter merged commit 739f5f8 into Kunstmaan:5.0 Nov 20, 2017
@Windvis Windvis deleted the bugfix/ppchooser-search branch June 6, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diskwriter diskwriter diskwriter approved these changes

@FVKVN FVKVN Awaiting requested review from FVKVN

@dbeerten dbeerten Awaiting requested review from dbeerten

Assignees
No one assigned
Labels
Profile: Frontend Type: Bugfix
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Windvis @diskwriter @sandergo90