New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KunstmaanNodeSearchBundle] add keyword as data type #1793
Merged
Devolicious
merged 1 commit into
Kunstmaan:5.0
from
sandergo90:feature/elasticsearch-keyword
Jan 30, 2018
Merged
[KunstmaanNodeSearchBundle] add keyword as data type #1793
Devolicious
merged 1 commit into
Kunstmaan:5.0
from
sandergo90:feature/elasticsearch-keyword
Jan 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numkil
approved these changes
Jan 29, 2018
[KunstmaanNodeSearchBundle]: change data types Revert keyword to string for compability with 2.4
sandergo90
force-pushed
the
feature/elasticsearch-keyword
branch
from
January 30, 2018 13:26
fc569b5
to
d61a441
Compare
Devolicious
pushed a commit
that referenced
this pull request
Apr 13, 2018
…pport bundles 3.6 websites on servers with ES6 (#1877) * [NodeSearchBundle]: fix request scope * [NodeSearchBundle] Make NodeSearcher properties protected for extending * [NodeSearchBundle]: add possibility to index multiple regions [NodeSearchBundle]: make contexts default array, and merge default * [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Change ruflin elastica version [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Add changelog * move boost from mapping to query + allow text as type for elasticsearch 5.0 * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children (#1550) [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle][SearchBundle] Multi domain/language search population fix (#1635) * squash commits * Analyzer info in command * Typo fix * typo * [NodeSearchBundle]: check if we have html * [NodeSearchBundle] shards and replicas configurable [NodeSearchBundle] default values shards/replicas * [SearchBundle][FIX] Populate command failing * [SearchBundle] Convert analyzer languages config to lowercase to prevent config mismatch because of case sensitivity * [SearchBundle] SetupIndex command failing when overwriting nodeconfiguration with own file. * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle] add punctuation to kuma_ngram tokenizer * [NodeSearchBundle] added extra properties for elasticsearch mapping (#1794) * [KunstmaanNodeSearchBundle] add keyword as data type (#1793) [KunstmaanNodeSearchBundle]: change data types Revert keyword to string for compability with 2.4 * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] backport fixes * [allbundles] bump phpversions
Devolicious
pushed a commit
that referenced
this pull request
Apr 27, 2018
* [SeoBundle]: change meta length (#1520) [SeoBundle]: change translations * [SeoBundle] Refactor seo description to be longer according to google's new length (#1797) * [NodeSearchBundle] [SearchBundle] ElasticSearch Backport so we can support bundles 3.6 websites on servers with ES6 (#1877) * [NodeSearchBundle]: fix request scope * [NodeSearchBundle] Make NodeSearcher properties protected for extending * [NodeSearchBundle]: add possibility to index multiple regions [NodeSearchBundle]: make contexts default array, and merge default * [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Change ruflin elastica version [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Add changelog * move boost from mapping to query + allow text as type for elasticsearch 5.0 * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children (#1550) [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle][SearchBundle] Multi domain/language search population fix (#1635) * squash commits * Analyzer info in command * Typo fix * typo * [NodeSearchBundle]: check if we have html * [NodeSearchBundle] shards and replicas configurable [NodeSearchBundle] default values shards/replicas * [SearchBundle][FIX] Populate command failing * [SearchBundle] Convert analyzer languages config to lowercase to prevent config mismatch because of case sensitivity * [SearchBundle] SetupIndex command failing when overwriting nodeconfiguration with own file. * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle] add punctuation to kuma_ngram tokenizer * [NodeSearchBundle] added extra properties for elasticsearch mapping (#1794) * [KunstmaanNodeSearchBundle] add keyword as data type (#1793) [KunstmaanNodeSearchBundle]: change data types Revert keyword to string for compability with 2.4 * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] backport fixes * [allbundles] bump phpversions * update changelog * [AdminlistBundle] fixed type from string to array (#1925)
JZuidema
pushed a commit
to e-sites/KunstmaanBundlesCMS
that referenced
this pull request
Jun 22, 2018
…#1936) * [SeoBundle]: change meta length (Kunstmaan#1520) [SeoBundle]: change translations * [SeoBundle] Refactor seo description to be longer according to google's new length (Kunstmaan#1797) * [NodeSearchBundle] [SearchBundle] ElasticSearch Backport so we can support bundles 3.6 websites on servers with ES6 (Kunstmaan#1877) * [NodeSearchBundle]: fix request scope * [NodeSearchBundle] Make NodeSearcher properties protected for extending * [NodeSearchBundle]: add possibility to index multiple regions [NodeSearchBundle]: make contexts default array, and merge default * [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Change ruflin elastica version [KunstmaanNodeSearchBundle]: upgrade elastica to 5.1 Add changelog * move boost from mapping to query + allow text as type for elasticsearch 5.0 * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children (Kunstmaan#1550) [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle] Bugfix for indexing StructuredNodes and children * [NodeSearchBundle][SearchBundle] Multi domain/language search population fix (Kunstmaan#1635) * squash commits * Analyzer info in command * Typo fix * typo * [NodeSearchBundle]: check if we have html * [NodeSearchBundle] shards and replicas configurable [NodeSearchBundle] default values shards/replicas * [SearchBundle][FIX] Populate command failing * [SearchBundle] Convert analyzer languages config to lowercase to prevent config mismatch because of case sensitivity * [SearchBundle] SetupIndex command failing when overwriting nodeconfiguration with own file. * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle][FIX] SetupIndex command failing * [SearchBundle] add punctuation to kuma_ngram tokenizer * [NodeSearchBundle] added extra properties for elasticsearch mapping (Kunstmaan#1794) * [KunstmaanNodeSearchBundle] add keyword as data type (Kunstmaan#1793) [KunstmaanNodeSearchBundle]: change data types Revert keyword to string for compability with 2.4 * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] Elastic search version 6 support * [NodeSearchBundle] backport fixes * [allbundles] bump phpversions * update changelog * [AdminlistBundle] fixed type from string to array (Kunstmaan#1925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of elasticsearch 5.x, the string data type is deprecated and replaced by "keyword" and "text".
https://www.elastic.co/guide/en/elasticsearch/reference/5.5/string.html
When having old indexes with the string datatype, it will stil work because elasticsearch is able to auto upgrade those fields. But when you have special types, the auto upgrade does not work and we need to be able to use the "keyword" datatype.