[AllBundles]: Backport pr #1767 but keeping BC #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
acrobat
commented
Feb 18, 2018
acrobat
commented
| Q | A |
|---|---|
| Bug fix? | no (cleanup) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Fixed tickets | related to #1767 |
acrobat
force-pushed
the
backport-unused-parameter-remove
branch
2 times, most recently
from
0b32063
to
cf38dd3
Compare
sandergo90
reviewed
Feb 19, 2018
| @trigger_error(sprintf('Passing the "container" as the sixth argument in "%s" is deprecated in KunstmaanConfigBundle 5.1 and will be removed in KunstmaanConfigBundle 6.0. Remove the "container" argument from your service definition.', __METHOD__), E_USER_DEPRECATED); | ||
|
|
||
| $this->formFactory = func_get_arg(6); | ||
|
|
There was a problem hiding this comment.
The services.yml file needs to be updated to.
There was a problem hiding this comment.
And I also think we need to keep the container variable set. Because when people are still using the container, they will still get an error because the private $container does not exist anymore.
There was a problem hiding this comment.
The container propery was private and there is no getter defined in the controller, so extending the controller will not have the container property available in user code. So I think we can safely remove the property
sandergo90
changed the title
acrobat
force-pushed
the
backport-unused-parameter-remove
branch
from
cf38dd3
to
892552d
Compare
sandergo90
approved these changes
Feb 19, 2018
mtnorthrop
pushed a commit
to mtnorthrop/KunstmaanBundlesCMS
that referenced
this pull request
Mar 1, 2018
sandergo90
pushed a commit
to janb87/KunstmaanBundlesCMS
that referenced
this pull request
Mar 5, 2018
[AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831)
sandergo90
pushed a commit
to janb87/KunstmaanBundlesCMS
that referenced
this pull request
Mar 5, 2018
…1831) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831)
sandergo90
pushed a commit
to janb87/KunstmaanBundlesCMS
that referenced
this pull request
Mar 5, 2018
…1831) [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831)
sandergo90
pushed a commit
to janb87/KunstmaanBundlesCMS
that referenced
this pull request
Mar 5, 2018
…1831) [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831)
sandergo90
pushed a commit
to sandergo90/KunstmaanBundlesCMS
that referenced
this pull request
Mar 28, 2018
…maan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789) [NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791) [TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788) [AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859) Reset event listeners after submit + fixed serialization of form data [LeadGenerationBundle]: add extras [NodeBundle]: improve URL chooser external (Kunstmaan#1852) [AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850) [NodeBundle]: deprecate service function (Kunstmaan#1840) [AllBundles]: Linting changes (Kunstmaan#1867) Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder Remove all other eslint / stylelint config [GeneratorBundle] Add imagemin task to groundcontrol (Kunstmaan#1870) [NodeBundle]: allow to set icon for tree (Kunstmaan#1790) Change upgrade guide [NodeBundle]: remove deprecation annotation Revert to php 5 code CHange upgrade guide
sandergo90
pushed a commit
to sandergo90/KunstmaanBundlesCMS
that referenced
this pull request
Mar 28, 2018
…maan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789) [NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791) [TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788) [AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859) Reset event listeners after submit + fixed serialization of form data [LeadGenerationBundle]: add extras [NodeBundle]: improve URL chooser external (Kunstmaan#1852) [AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850) [NodeBundle]: deprecate service function (Kunstmaan#1840) [AllBundles]: Linting changes (Kunstmaan#1867) Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder Remove all other eslint / stylelint config [GeneratorBundle] Add imagemin task to groundcontrol (Kunstmaan#1870) [NodeBundle]: allow to set icon for tree (Kunstmaan#1790) Change upgrade guide [NodeBundle]: remove deprecation annotation Revert to php 5 code CHange upgrade guide
sandergo90
pushed a commit
to sandergo90/KunstmaanBundlesCMS
that referenced
this pull request
Apr 3, 2018
…in controller classes (Kunstmaan#1690) [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789) [NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791) [TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788) [AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859) Reset event listeners after submit + fixed serialization of form data [LeadGenerationBundle]: add extras [NodeBundle]: improve URL chooser external (Kunstmaan#1852) [AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850) [NodeBundle]: deprecate service function (Kunstmaan#1840) [AllBundles]: Linting changes (Kunstmaan#1867) Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder Remove all other eslint / stylelint config [GeneratorBundle] Add imagemin task to groundcontrol (Kunstmaan#1870) [NodeBundle]: allow to set icon for tree (Kunstmaan#1790) Change upgrade guide [NodeBundle]: remove deprecation annotation Revert to php 5 code CHange upgrade guide
sandergo90
pushed a commit
to sandergo90/KunstmaanBundlesCMS
that referenced
this pull request
Apr 3, 2018
…in controller classes (Kunstmaan#1690) [SensiolabsInsight] Changed method visibility for non-action methods in controller classes (Kunstmaan#1690) [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789) [NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791) [TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788) [AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859) Reset event listeners after submit + fixed serialization of form data [LeadGenerationBundle]: add extras [NodeBundle]: improve URL chooser external (Kunstmaan#1852) [AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850) [NodeBundle]: deprecate service function (Kunstmaan#1840) [AllBundles]: Linting changes (Kunstmaan#1867) Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder Remove all other eslint / stylelint config [GeneratorBundle] Add imagemin task to groundcontrol (Kunstmaan#1870) [NodeBundle]: allow to set icon for tree (Kunstmaan#1790) Change upgrade guide [NodeBundle]: remove deprecation annotation Revert to php 5 code CHange upgrade guide
sandergo90
added a commit
to sandergo90/KunstmaanBundlesCMS
that referenced
this pull request
Apr 3, 2018
Reorder Add media bundle [SensiolabsInsight] Changed method visibility for non-action methods in controller classes (Kunstmaan#1690) [SensiolabsInsight] Changed method visibility for non-action methods in controller classes (Kunstmaan#1690) [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789) [NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791) [TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788) [AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769) [AllBundles] Backport the removal of unused parameters (Kunstmaan#1838) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859) Reset event listeners after submit + fixed serialization of form data [LeadGenerationBundle]: add extras [NodeBundle]: improve URL chooser external (Kunstmaan#1852) [AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850) [NodeBundle]: deprecate service function (Kunstmaan#1840) [AllBundles]: Linting changes (Kunstmaan#1867) Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder Remove all other eslint / stylelint config [GeneratorBundle] Add imagemin task to groundcontrol (Kunstmaan#1870) [NodeBundle]: allow to set icon for tree (Kunstmaan#1790) Change upgrade guide [NodeBundle]: remove deprecation annotation Revert to php 5 code CHange upgrade guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.