Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] Make it possible to search in all PagePartChoosers #1854

Merged
merged 1 commit into from Mar 14, 2018
Merged

[AdminBundle] Make it possible to search in all PagePartChoosers #1854

merged 1 commit into from Mar 14, 2018

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Feb 26, 2018

Make it possible to search in all PagePartChoosers on the page

Also refactor the code to make it more readable

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #1775

@sandergo90 sandergo90 changed the title [AdminBundle] PagePartChooser: Make it possible to search in all PagePartChoosers o… [AdminBundle] Make it possible to search in all PagePartChoosers Feb 27, 2018
import {SELECTORS} from './config';
import {initSearch} from './pagepart-search/initSearch';


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 too many empty lines

…n the page

Also refactor the code to make it more readable
@BennoDev
Copy link

It seems the code quality errors are php/symfony related, so frontend is approved

@sandergo90 sandergo90 merged commit bb7f9df into Kunstmaan:5.0 Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants