[AdminBundle] Fix escaping of img src attributes in WYSIWYG fields #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same seems to be happening to href-attributes of a-tags. Could this PR
be extended to fix that too?
…On Mar 1, 2018 18:02, "Mark Northrop" ***@***.***> wrote:
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #1857
<#1857>
The MediaTokenTransformer::reverseTransform() method uses the
Crawler::html() method to produce the HTML it returns, but this method
automatically URL-encodes the src attribute of image tags.
This PR does a search and replace on the final HTML to make sure that the
square brackets used for the tokens are preserved.
*NB: the Symfony docs mention that the DomCrawler Component is not
designed to re-dump HTML, and so it might be worth considering looking for
a different tool to use in this class. (See
https://symfony.com/doc/current/components/dom_crawler.html#component-dom-crawler-dumping
<https://symfony.com/doc/current/components/dom_crawler.html#component-dom-crawler-dumping>).*
------------------------------
You can view, comment on, or merge this pull request online at:
#1858
Commit Summary
- Escape square brackets in img tags
File Changes
- *M* src/Kunstmaan/AdminBundle/Form/MediaTokenTransformer.php
<https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1858/files#diff-0>
(15)
- *A* src/Kunstmaan/AdminBundle/Tests/Form/
MediaTokenTransformerTest.php
<https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1858/files#diff-1>
(37)
Patch Links:
- https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1858.patch
- https://github.com/Kunstmaan/KunstmaanBundlesCMS/pull/1858.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1858>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ACrShLYNRMBwe1JvwYpk70X4L3y5bsS9ks5taCmdgaJpZM4SYp0M>
.
|
|
No problem, I've updated the PR to decode |
|
@mtnorthrop Thanks! This is quite an annoying bug, any chance of a quick merge and release? |
|
I hope this can be reviewed, merged and released soon, because in AdminBundle 5.0.4 all internal links and images added to the WYSIWYG fields are currently broken, and this PR fixes the issue. |
sandergo90
approved these changes
Mar 5, 2018
|
@mtnorthrop I've reviewed it and merged it now. We will create a new release tomorrow! |
|
@sandergo90 Thank you! |
|
@mtnorthrop new release submitted! |
Ch3F24
pushed a commit
to Ch3F24/KunstmaanBundlesCMS
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MediaTokenTransformer::reverseTransform()method uses theCrawler::html()method to produce the HTML it returns, but this method automatically URL-encodes thesrcattribute of image tags.This PR does a search and replace on the final HTML to make sure that the square brackets used for the tokens are preserved.
NB: the Symfony docs mention that the DomCrawler Component is not designed to re-dump HTML, and so it might be worth considering looking for a different tool to use in this class. (See https://symfony.com/doc/current/components/dom_crawler.html#component-dom-crawler-dumping).