-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NodeSearchBundle] Elastic search version 6 support #1875
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/Kunstmaan/NodeSearchBundle/Helper/ElasticSearchUtil.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
namespace Kunstmaan\NodeSearchBundle\Helper; | ||
|
||
/** | ||
* Class ElasticSearchUtil | ||
*/ | ||
final class ElasticSearchUtil | ||
{ | ||
/** | ||
* @return bool | ||
*/ | ||
public static function useVersion6() | ||
{ | ||
return (PHP_MAJOR_VERSION == 7 && !class_exists('\Elastica\Tool\CrossIndex')); | ||
} | ||
} |
50 changes: 50 additions & 0 deletions
50
src/Kunstmaan/NodeSearchBundle/Resources/doc/ElasticSearch.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Elastic search support | ||
|
||
We have added support for Elastic search up to version 6.x. | ||
|
||
## Dynamic configuration | ||
For the mapping and configuration we detect which version of the library your project is using. | ||
Dependencies for using the configuration of version 6 is that your project uses PHP 7 and ruflin/elastica >= 6.0. | ||
|
||
## Difference between versions | ||
|
||
The biggest change in version 6, is that Elastica has dropped support for the "_all" meta field. | ||
(see https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-all-field.html) | ||
|
||
When using version 6.x, then you will no longer be able to use the "include_in_all" and "index => 'not_analysed". | ||
use 'index => false' instead. Also some of the index types have been changed and some fields are no longer indexed (like the 'created' and 'updated' fields). | ||
|
||
### Example | ||
|
||
Some examples of the mapping that have changed (for the kunstmaan_node_search extension): | ||
|
||
``` | ||
'node_id' => [ | ||
'type' => 'integer', | ||
'include_in_all' => false, | ||
'index' => 'not_analyzed' | ||
], | ||
... | ||
'view_roles' => [ | ||
'type' => 'string', | ||
'include_in_all' => true, | ||
'index' => 'not_analyzed', | ||
], | ||
``` | ||
|
||
in | ||
|
||
|
||
``` | ||
'node_id' => [ | ||
'type' => 'integer', | ||
], | ||
... | ||
'view_roles' => [ | ||
'type' => 'keyword', | ||
], | ||
``` | ||
|
||
### Link to elastic search documentation | ||
|
||
https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading the https://www.elastic.co/guide/en/elasticsearch/reference/current/fielddata.html article and like they say, it's not a good idea to use this fielddata element because it will cause a lot of memory issues. We should use https://www.elastic.co/guide/en/elasticsearch/reference/current/doc-values.html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, using doc_values seems a good alternative, however, I don't think we should prohibit it. We are not using fielddata, but allowing that it is used as a mapping value. I'll add the doc_values as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, super