[MediaBundle]: bulk move media in folders #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlebkowski
reviewed
Apr 3, 2018
|
|
||
| foreach ($mediaIds as $mediaId) { | ||
| /** @var Media $media */ | ||
| $media = $mediaRepo->getMedia($mediaId); |
There was a problem hiding this comment.
Fetching from database in a loop? Not a good idea. A simple UPDATE query would do fine here.
There was a problem hiding this comment.
@mlebkowski Correct! Changed ;)
sandergo90
force-pushed
the
feature/media-move
branch
from
cd9f9ca
to
96a3ce4
Compare
mlebkowski
reviewed
Apr 4, 2018
| $mediaIds = explode(',', $form->getData()['media']); | ||
|
|
||
| foreach ($mediaIds as $mediaId) { | ||
| $mediaRepo->moveToFolder($mediaId, $folder->getId()); |
There was a problem hiding this comment.
This is still executing queries in a loop. I was thinking more like:
$mediaRepo->createQueryBuilder('media')
->update()
->set('media.folder', $folder->getId())
->where('media.id in (:mediaIds)')
->setParameter('mediaIds', $mediaIds)
->getQuery()
->execute();There was a problem hiding this comment.
True, didn't see that ;) I've changed it now.
sandergo90
force-pushed
the
feature/media-move
branch
from
96a3ce4
to
44dd3df
Compare
Change save to update query Change to one update query Remove moveToFolder action
sandergo90
force-pushed
the
feature/media-move
branch
from
44dd3df
to
8be5802
Compare
Numkil
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to possibility to move media in bulk to another folder.