Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle]: toolbar should check if logged in in main firewall #1941

Merged
merged 1 commit into from Apr 27, 2018
Merged

[AdminBundle]: toolbar should check if logged in in main firewall #1941

merged 1 commit into from Apr 27, 2018

Conversation

sandergo90
Copy link
Contributor

@sandergo90 sandergo90 commented Apr 25, 2018 •
edited

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

This PR fixes some things:

  • First of all, it should only listen to master request
  • Secondly, the default value of the toolbar_firewall_names should be set to "main".
  • provider_keys has been deprecated in favor of toolbar_firewall_names
  • new config value admin_firewall_name has been added to specify which firewall we need to check for a authenticated user.

@sandergo90 sandergo90 added this to the 5.0.7 milestone Apr 25, 2018
@sandergo90
[AdminBundle]: toolbar should check if logged in in main firewall
e34e58c 
Rename logged in to authenticated

Update toolbar listener
@Devolicious Devolicious merged commit 960b0af into Kunstmaan:5.0 Apr 27, 2018
Devolicious added a commit that referenced this pull request Apr 27, 2018
@Devolicious
Merge branch '5.0'
dd4291f 
* 5.0:
  [AdminListBundle] avoid translations freakout when the key is true or false without escaping (#1909)
  [AdminListBundle][MediaBundle] remove duplicate pagination and broken switch pagination limit (#1927)
  [AdminBundle]: toolbar should check if logged in in main firewall (#1941)
diskwriter added a commit to diskwriter/KunstmaanBundlesCMS that referenced this pull request Apr 28, 2018
@diskwriter
Merge branch 'master' of github.com:Kunstmaan/KunstmaanBundlesCMS
33ac80c 
* 'master' of github.com:Kunstmaan/KunstmaanBundlesCMS:
  Fixed incorrect indentation (Kunstmaan#1952)
  fix tests
  [Translations] New Crowdin translations (Kunstmaan#1837)
  [AdminListBundle] avoid translations freakout when the key is true or false without escaping (Kunstmaan#1909)
  [ArticleBundle] Add deprecation error when using entities directly th… (Kunstmaan#1921)
  [AdminListBundle][MediaBundle] remove duplicate pagination and broken switch pagination limit (Kunstmaan#1927)
  [AdminBundle]: toolbar should check if logged in in main firewall (Kunstmaan#1941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devolicious Devolicious Devolicious approved these changes

Assignees
No one assigned
Labels
Profile: Backend Type: Bugfix
Projects
None yet
Milestone
5.0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sandergo90 @Devolicious