[AllBundles] Mark services used in controller as public #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
approved these changes
May 11, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
ProfessorKuma
approved these changes
May 11, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
ProfessorKuma
approved these changes
May 11, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
ProfessorKuma
approved these changes
May 11, 2018
There was a problem hiding this comment.
Hi @acrobat, your PR passed all our requirements.
Thank you for contributing!
Numkil
approved these changes
May 14, 2018
Devolicious
added a commit
that referenced
this pull request
May 15, 2018
* master: (93 commits) Pass correct constructor arguments to the translator service (#1968) Mark services used in controller as public (#1972) Fix unquoted parameter in routing generator (#1973) [UtilitiesBundle] Make parameter kunstmaan_utilities.cipher.secret op… (#1939) Revert "[GeneratorBundle] Remove unused .babelrc (#1950)" [KunstmaanFormBundle]: batchsize is not initialized (#1976) Fixed active menu item when having more than 1 configuration entity (#1964) Make the router service alias public (#1969) Mark the translator service aliases as public (#1970) Fixed yaml translation file deprecations (#1971) [AdminListBundle] fixes forgotten commit new feature changeablelimitinterface (#1967) [NodeSearchBundle]: elasticsearch util should check the running version of elasticsearch (#1940) (#1965) [AdminListBundle][MediaBundle] Changeablelimitinterface implemented and fixes some bugs (#1905) Deprecate container usage in the slug router (#1960) [AllBundles] Implement reset method in datacollectors (#1959) [AdminBundle] update frontend packages (#1946) [AdminBundle] Messages are already translated by symfony (#1954) Bundle default config reference docs (#1951) [GeneratorBundle] Remove unused .babelrc (#1950) [TranslatorBundle]: change toolbar data collector to show message (#1947) ...
sandergo90
pushed a commit
to sandergo90/KunstmaanBundlesCMS
that referenced
this pull request
May 15, 2018
* master: (93 commits) Pass correct constructor arguments to the translator service (Kunstmaan#1968) Mark services used in controller as public (Kunstmaan#1972) Fix unquoted parameter in routing generator (Kunstmaan#1973) [UtilitiesBundle] Make parameter kunstmaan_utilities.cipher.secret op… (Kunstmaan#1939) Revert "[GeneratorBundle] Remove unused .babelrc (Kunstmaan#1950)" [KunstmaanFormBundle]: batchsize is not initialized (Kunstmaan#1976) Fixed active menu item when having more than 1 configuration entity (Kunstmaan#1964) Make the router service alias public (Kunstmaan#1969) Mark the translator service aliases as public (Kunstmaan#1970) Fixed yaml translation file deprecations (Kunstmaan#1971) [AdminListBundle] fixes forgotten commit new feature changeablelimitinterface (Kunstmaan#1967) [NodeSearchBundle]: elasticsearch util should check the running version of elasticsearch (Kunstmaan#1940) (Kunstmaan#1965) [AdminListBundle][MediaBundle] Changeablelimitinterface implemented and fixes some bugs (Kunstmaan#1905) Deprecate container usage in the slug router (Kunstmaan#1960) [AllBundles] Implement reset method in datacollectors (Kunstmaan#1959) [AdminBundle] update frontend packages (Kunstmaan#1946) [AdminBundle] Messages are already translated by symfony (Kunstmaan#1954) Bundle default config reference docs (Kunstmaan#1951) [GeneratorBundle] Remove unused .babelrc (Kunstmaan#1950) [TranslatorBundle]: change toolbar data collector to show message (Kunstmaan#1947) ... [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [AllBundle] Fix unused method, property, variable or parameter (Kunstmaan#1767) * Unused method, property, variable or parameter * Unused variable * Update BundleVersionDataCollector.php * DocBlock fix [UtilitiesBundle] Commands as services and mark commands as final (Kunstmaan#1789) [NodeBundle] Commands as services and mark commands as final (Kunstmaan#1791) [TranslatorBundle] Commands as services and mark commands as final (Kunstmaan#1788) [AdminListBundle][5.1] Deprecate direct container access in controllers (Kunstmaan#1769) [AdminBundle] refactor media token transformer (Kunstmaan#1827) [AdminListBundle] Fix Export Exception namespace (Kunstmaan#1825) [AdminBundle]: readd the extrajavascript block (Kunstmaan#1829) [MediaBundle] Bulk upload fix (Kunstmaan#1834) [AdminListBundle]: ->loadTemplate() is only for internal use.. (Kunstmaan#1846) [PagePartBundle] Fix for PHP 7.2 - value passed to count() cannot be null (Kunstmaan#1849) update changelog update changelog [AdminBundle]: Fix fosuser bundle inheritance deprecation (Kunstmaan#1831) [LeadGenerationBundle]: remove jquery dependency leadgeneration bundle (Kunstmaan#1859) Reset event listeners after submit + fixed serialization of form data [LeadGenerationBundle]: add extras [NodeBundle]: improve URL chooser external (Kunstmaan#1852) [AllBundles] 5.1 upgrade file with all current changes (Kunstmaan#1850) [NodeBundle]: deprecate service function (Kunstmaan#1840) [AllBundles]: Linting changes (Kunstmaan#1867) Change the eslint config for the AdminBundle to make it lint the code inside the jsnext folder instead of the js folder Remove all other eslint / stylelint config [DashboardBundle]: add new google api client
This was referenced Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will allow us to support sf4 quicker and afterwards we can do refactor iterations to cleanup certain controllers. This pr marks a first batch of services as public but I will create more pr's as I discover more deprecations. This covers a lot of the private service deprecations from a clean install with demo site.