Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeneratorBundle] Update gulp version #2008

Merged
merged 1 commit into from Jun 7, 2018
Merged

Conversation

dbeerten
Copy link
Contributor

@dbeerten dbeerten commented Jun 7, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbeerten, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbeerten, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbeerten, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbeerten, your PR passed all our requirements.

Thank you for contributing!

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbeerten, your PR passed all our requirements.

Thank you for contributing!

@diskwriter diskwriter added this to the 6.0.0 milestone Jun 7, 2018
Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dbeerten, your PR needs some changes

  • It seems that you should have submitted to master.
  • This PR seems to need a milestone of a minor release.

@diskwriter diskwriter merged commit eb641cf into Kunstmaan:6.0 Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants